-
Notifications
You must be signed in to change notification settings - Fork 9
[lab] CS537 Spring 2018 Project 5 #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a CS537 Spring 2018 Project 5 task for file system checking to the courselab benchmark. The task requires implementing an xv6 file system checker (xcheck) that validates file system images for 13 different types of consistency errors.
Changes:
- Added task description with detailed specifications for implementing a file system checker
- Created preprocessing script to clone xv6 and ostep-projects repositories and generate 14 test file system images (1 valid, 13 with specific errors)
- Implemented evaluation script that tests all error cases, usage handling, and valid image processing
- Added course metadata to courses.json for CS537 Spring 2018
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| task.md | Comprehensive task description specifying the file system checker requirements, error messages, and hints |
| preprocess.sh | Setup script that clones dependencies, builds mkfs, and generates test images with specific file system inconsistencies |
| evaluate.sh | Test harness that validates xcheck implementation against all 16 test cases (usage, missing file, valid image, and 13 error types) |
| config.json | Task configuration with timeout, tags, and artifact paths |
| compose.yaml | Docker compose configuration using gcc:12 image |
| courses.json | Added CS537 Spring 2018 course entry with metadata |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| is provided, you should print the usage error shown below: | ||
| ``` | ||
| prompt> xcheck | ||
| Usage: xcheck <file_system_image> |
Copilot
AI
Jan 27, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The usage message has a trailing space after <file_system_image>. While this doesn't cause test failures (since evaluate.sh strips trailing whitespace with sed), it's cleaner to remove the trailing space for consistency.
| Usage: xcheck <file_system_image> | |
| Usage: xcheck <file_system_image> |
| If the file system image does not exist, you should print the error `image not | ||
| found.` to standard error and exit with the error code of 1. | ||
|
|
||
| If the checker detects any one of the 12 errors above, it should print the |
Copilot
AI
Jan 27, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation states "any one of the 12 errors above" but actually lists 13 distinct error conditions (numbered 1-13 in the preceding list). This should be corrected to say "13 errors" to match the actual number of error cases.
| If the checker detects any one of the 12 errors above, it should print the | |
| If the checker detects any one of the 13 errors above, it should print the |
Description
This project was seen as part of CS537 in Spring 2018
See original repo: https://github.com/remzi-arpacidusseau/ostep-projects
Testing
Did a simple test with openai/gpt-5.2-2025-12-11:
Model ran, and successfully completed the project:
Checklist