refactor!: remove Sysdig Secure tools, redirect to @sysdig/secure-mcp-server#87
Merged
Conversation
…-server BREAKING CHANGE: list_runtime_events, get_event_info and get_event_process_tree have been removed from this server. Use the dedicated @sysdig/secure-mcp-server npm package for Sysdig Secure workflows. SysQL tools (generate_sysql, run_sysql) remain because they target both Monitor and Secure datasets.
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the MCP server to be Monitor-focused by removing Sysdig Secure-specific MCP tools and client extensions, and directing Secure users to the dedicated @sysdig/secure-mcp-server package.
Changes:
- Removes Sysdig Secure tools (
list_runtime_events,get_event_info,get_event_process_tree) and their tests/integration coverage. - Deletes the process-tree client extension and trims the extended client interface accordingly; preserves
GetMyPermissions*via a newclient_permissions.go. - Updates documentation (
README.md, tools README, AGENTS) to reflect the new scope and migration path.
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Adds breaking-change notice and removes Secure tool docs/permission; repositions SysQL docs. |
| internal/infra/sysdig/mocks/client_extension.go | Regenerates mocks after removing process-tree methods from the extended interface. |
| internal/infra/sysdig/client_process_tree.go | Removes process-tree client extension implementation. |
| internal/infra/sysdig/client_process_tree_integration_test.go | Removes flaky integration tests tied to process-tree endpoints. |
| internal/infra/sysdig/client_permissions.go | Adds GetMyPermissions* client extension after splitting from process-tree file. |
| internal/infra/sysdig/client_extension.go | Updates extended client interface to drop process-tree response methods. |
| internal/infra/mcp/tools/tool_list_runtime_events.go | Removes Secure runtime events MCP tool. |
| internal/infra/mcp/tools/tool_list_runtime_events_test.go | Removes tests for the removed runtime events tool. |
| internal/infra/mcp/tools/tool_get_event_process_tree.go | Removes Secure process-tree MCP tool. |
| internal/infra/mcp/tools/tool_get_event_process_tree_test.go | Removes tests for the removed process-tree tool. |
| internal/infra/mcp/tools/tool_get_event_info.go | Removes Secure event-info MCP tool. |
| internal/infra/mcp/tools/tool_get_event_info_test.go | Removes tests for the removed event-info tool. |
| internal/infra/mcp/tools/README.md | Removes Secure tool table; adds pointer to @sysdig/secure-mcp-server; keeps SysQL tools. |
| cmd/server/main.go | Stops registering removed Secure tools; keeps SysQL + K8s Monitor tool registration. |
| AGENTS.md | Updates project positioning to Monitor-focused and points Secure users to the new package. |
Files not reviewed (1)
- internal/infra/sysdig/mocks/client_extension.go: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tembleking
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
list_runtime_events,get_event_info,get_event_process_tree) from this MCP server. Users who need them should install the new @sysdig/secure-mcp-server npm package, which provides full coverage of Sysdig Secure capabilities.generate_sysql,run_sysql) stay here since they can be used against both Monitor and Secure datasets.client_process_tree.go) and trimspolicy-events.readfrom the documented permissions.GetMyPermissions*(used by permission filtering) is preserved in a newclient_permissions.go.README.md,internal/infra/mcp/tools/README.mdandAGENTS.mdto reflect the new Monitor-focused scope and to point Secure users to the new npm package.Test plan
just check(fmt + fix + govulncheck + lint + tests) passes locallygo generate ./...regenerates mocks cleanly with the trimmed interface