Skip to content

feat: PgBouncer migration tooling - Stage 1: Config parser library - #5566

Open
renecannao wants to merge 6 commits into
v3.0from
feature/pgbouncer-compat
Open

feat: PgBouncer migration tooling - Stage 1: Config parser library#5566
renecannao wants to merge 6 commits into
v3.0from
feature/pgbouncer-compat

fix: address code review feedback from AI reviewers (#5566)

3f1027b
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Apr 3, 2026 in 14m 0s

Quality Gate failed

Failed conditions
1 Security Hotspot
E Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check failure on line 87 in lib/pgbouncer_compat/PgBouncer_ConfigParser.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 44 to the 25 allowed.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ1TiJ-KNywzTGnSgPEU&open=AZ1TiJ-KNywzTGnSgPEU&pullRequest=5566

Check failure on line 245 in lib/pgbouncer_compat/PgBouncer_ConfigConverter.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture "result" in a non-transient lambda.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ1TkiZOHkM_Q1xdPsPp&open=AZ1TkiZOHkM_Q1xdPsPp&pullRequest=5566

Check failure on line 29 in lib/pgbouncer_compat/PgBouncer_ShowCommands.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Call a function from <locale> instead of a function from <ctype.h>.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ1TkiY_HkM_Q1xdPsPn&open=AZ1TkiY_HkM_Q1xdPsPn&pullRequest=5566

Check warning on line 119 in test/tap/tests/unit/pgbouncer_converter_unit-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Hard-coded passwords are security-sensitive.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ1TkiRtHkM_Q1xdPsPj&open=AZ1TkiRtHkM_Q1xdPsPj&pullRequest=5566

Check failure on line 506 in lib/pgbouncer_compat/PgBouncer_ConfigParser.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 95 to the 25 allowed.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ1TiJ-KNywzTGnSgPEd&open=AZ1TiJ-KNywzTGnSgPEd&pullRequest=5566

Check failure on line 253 in lib/pgbouncer_compat/PgBouncer_ConfigConverter.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture "result" in a non-transient lambda.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ1TkiZOHkM_Q1xdPsPq&open=AZ1TkiZOHkM_Q1xdPsPq&pullRequest=5566

Check failure on line 64 in lib/pgbouncer_compat/PgBouncer_HBAParser.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Call a function from <locale> instead of a function from <ctype.h>.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ1TiJ9-NywzTGnSgPES&open=AZ1TiJ9-NywzTGnSgPES&pullRequest=5566

Check warning on line 113 in test/tap/tests/unit/pgbouncer_converter_unit-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Hard-coded passwords are security-sensitive.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ1TkiRtHkM_Q1xdPsPi&open=AZ1TkiRtHkM_Q1xdPsPi&pullRequest=5566

Check warning on line 91 in test/tap/tests/unit/pgbouncer_converter_unit-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Hard-coded passwords are security-sensitive.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ1TkiRtHkM_Q1xdPsPh&open=AZ1TkiRtHkM_Q1xdPsPh&pullRequest=5566

Check failure on line 602 in lib/pgbouncer_compat/PgBouncer_ConfigParser.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ1TiJ-KNywzTGnSgPEe&open=AZ1TiJ-KNywzTGnSgPEe&pullRequest=5566

Check failure on line 605 in lib/pgbouncer_compat/PgBouncer_ConfigParser.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ1TiJ-KNywzTGnSgPEh&open=AZ1TiJ-KNywzTGnSgPEh&pullRequest=5566

Check failure on line 13 in test/tap/tests/unit/pgbouncer_converter_unit-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this function-like macro with a C++ function or another construct.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ1TkiRtHkM_Q1xdPsPf&open=AZ1TkiRtHkM_Q1xdPsPf&pullRequest=5566

Check failure on line 18 in lib/pgbouncer_compat/PgBouncer_ShowCommands.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Call a function from <locale> instead of a function from <ctype.h>.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ1TkiY_HkM_Q1xdPsPm&open=AZ1TkiY_HkM_Q1xdPsPm&pullRequest=5566

Check failure on line 372 in lib/pgbouncer_compat/PgBouncer_ConfigConverter.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 33 to the 25 allowed.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ1TkiZOHkM_Q1xdPsPr&open=AZ1TkiZOHkM_Q1xdPsPr&pullRequest=5566

Check failure on line 105 in lib/pgbouncer_compat/PgBouncer_ConfigParser.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Call a function from <locale> instead of a function from <ctype.h>.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ1TiJ-KNywzTGnSgPEX&open=AZ1TiJ-KNywzTGnSgPEX&pullRequest=5566

Check failure on line 16 in test/tap/tests/unit/pgbouncer_config_parser_unit-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this function-like macro with a C++ function or another construct.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ1TiJ38NywzTGnSgPEP&open=AZ1TiJ38NywzTGnSgPEP&pullRequest=5566

Check failure on line 147 in lib/pgbouncer_compat/PgBouncer_ConfigParser.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Call a function from <locale> instead of a function from <ctype.h>.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ1TiJ-KNywzTGnSgPEa&open=AZ1TiJ-KNywzTGnSgPEa&pullRequest=5566

Check failure on line 40 in test/tap/tests/unit/pgbouncer_config_parser_unit-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 28 to the 25 allowed.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ1TiJ38NywzTGnSgPEQ&open=AZ1TiJ38NywzTGnSgPEQ&pullRequest=5566

Check failure on line 14 in test/tap/tests/unit/pgbouncer_config_parser_unit-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this function-like macro with a C++ function or another construct.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ1TiJ38NywzTGnSgPEO&open=AZ1TiJ38NywzTGnSgPEO&pullRequest=5566

Check failure on line 604 in lib/pgbouncer_compat/PgBouncer_ConfigParser.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ1TiJ-KNywzTGnSgPEg&open=AZ1TiJ-KNywzTGnSgPEg&pullRequest=5566

Check failure on line 12 in test/tap/tests/unit/pgbouncer_show_commands_unit-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this function-like macro with a C++ function or another construct.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ1TkiYrHkM_Q1xdPsPk&open=AZ1TkiYrHkM_Q1xdPsPk&pullRequest=5566

Check failure on line 100 in lib/pgbouncer_compat/PgBouncer_ConfigParser.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Call a function from <locale> instead of a function from <ctype.h>.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ1TiJ-KNywzTGnSgPEW&open=AZ1TiJ-KNywzTGnSgPEW&pullRequest=5566

Check failure on line 14 in test/tap/tests/unit/pgbouncer_converter_unit-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this function-like macro with a C++ function or another construct.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ1TkiRtHkM_Q1xdPsPg&open=AZ1TkiRtHkM_Q1xdPsPg&pullRequest=5566

Check failure on line 39 in lib/pgbouncer_compat/PgBouncer_ShowCommands.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Call a function from <locale> instead of a function from <ctype.h>.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ1TkiY_HkM_Q1xdPsPo&open=AZ1TkiY_HkM_Q1xdPsPo&pullRequest=5566

Check failure on line 65 in lib/pgbouncer_compat/PgBouncer_HBAParser.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ1TiJ9-NywzTGnSgPER&open=AZ1TiJ9-NywzTGnSgPER&pullRequest=5566