Skip to content

fix(pgsql): classify backend error severity from non-localized field #5864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rayshoo wants to merge 2 commits into
base: v3.0
Choose a base branch
from
+3 −1
Open

fix(pgsql): classify backend error severity from non-localized field #5864

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f53057
fix(pgsql): classify backend error severity from non-localized field
rayshoo Jun 26, 2026
9b10169
fix(pgsql): apply non-localized severity fallback to extended error text
rayshoo Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/PgSQL_Error_Helper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,7 @@ void PgSQL_Error_Helper::fill_extended_error_info(PgSQL_ErrorInfo& err_info, con

if (ext_fields & PGSQL_ERROR_FIELD_TEXT) {
val = PQresultErrorField(result, PG_DIAG_SEVERITY_NONLOCALIZED);
if (val == nullptr) val = PQresultErrorField(result, PG_DIAG_SEVERITY);
err_info.ext_info->text = identify_error_severity(val ? val : "");
}

Expand Down Expand Up @@ -447,7 +448,8 @@ void PgSQL_Error_Helper::fill_error_info(PgSQL_ErrorInfo& err_info, const PGresu
}
const char* sqlstate = PQresultErrorField(result, PG_DIAG_SQLSTATE);
const char* message = PQresultErrorField(result, PG_DIAG_MESSAGE_PRIMARY);
const char* severity = PQresultErrorField(result, PG_DIAG_SEVERITY);
const char* severity = PQresultErrorField(result, PG_DIAG_SEVERITY_NONLOCALIZED);
if (severity == nullptr) severity = PQresultErrorField(result, PG_DIAG_SEVERITY);
Comment thread
rayshoo marked this conversation as resolved.
fill_error_info(err_info, sqlstate ? sqlstate : "00000", message ? message : "", severity ? severity : "");
fill_extended_error_info(err_info, result, ext_fields);
}