Skip to content

ci: fetch LFS objects in sanitizer workflows - #6060

Merged
renecannao merged 1 commit into
v3.0from
agent/sanitizer-lfs-checkout
Aug 13, 2026
Merged

ci: fetch LFS objects in sanitizer workflows#6060
renecannao merged 1 commit into
v3.0from
agent/sanitizer-lfs-checkout

Conversation

@renecannao

@renecannao renecannao commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

What changed

Enable Git LFS in the pinned checkout steps used by the ASan coverage and TSan workflow_run jobs.

Root cause

PR #6048 vendors the AWS SDK archive as an LFS object. These two default-branch workflows checked out the triggering SHA without LFS, so the build received the pointer text and reported a vendored SDK checksum mismatch before any sanitizer tests ran.

Impact

Future sanitizer runs check out the real vendored archive while retaining the existing Docker-isolated build and test flow.

Validation

  • Both workflow YAML files parse successfully.
  • Each affected checkout step contains exactly one lfs: true input.
  • git diff --check passes.

Related: #6048


Summary by cubic

Fetch Git LFS objects in ASan coverage and TSan sanitizer workflows so builds use the real vendored AWS SDK archive. Previously these jobs checked out without LFS and saw pointer files, causing checksum mismatches; now they fetch LFS and proceed with tests.

  • Set lfs: true on the pinned actions/checkout steps in .github/workflows/CI-unit-tests-asan-coverage.yml and .github/workflows/CI-unit-tests-tsan.yml.
  • No change to the Docker-isolated build/test flow; only the checkout behavior changes.
  • Review: confirm YAML parses and lfs: true appears once in each affected checkout step.

Written for commit ce8aa36. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Chores
    • Updated automated test workflows to retrieve Git LFS-managed files during repository checkout.
    • Improved reliability of AddressSanitizer, ThreadSanitizer, and coverage test runs.

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: aab2eec9-ebd5-478a-b99a-befb25c6b981

📥 Commits

Reviewing files that changed from the base of the PR and between 5980f9a and ce8aa36.

📒 Files selected for processing (2)
  • .github/workflows/CI-unit-tests-asan-coverage.yml
  • .github/workflows/CI-unit-tests-tsan.yml
📜 Recent review details
⏰ Context from checks skipped due to timeout. (1)
  • GitHub Check: Gitar
🔇 Additional comments (2)
.github/workflows/CI-unit-tests-asan-coverage.yml (1)

100-100: LGTM!

.github/workflows/CI-unit-tests-tsan.yml (1)

90-90: LGTM!


📝 Walkthrough

Walkthrough

The ASAN coverage and TSAN GitHub Actions workflows now enable Git LFS during repository checkout.

Changes

CI Git LFS Checkout

Layer / File(s) Summary
Enable Git LFS in CI checkout
.github/workflows/CI-unit-tests-asan-coverage.yml, .github/workflows/CI-unit-tests-tsan.yml
Both checkout steps now use lfs: true.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Mergeability Score: ⚪ Minimal · up to ce8aa

This PR enables Git LFS for the two sanitizer workflow checkouts so vendored archives are fetched correctly; no actionable merge-blocking risk remains beyond normal checks.

Possibly related PRs

Poem

A bunny checked out code with care,
With LFS files hopping through the air.
ASAN and TSAN now align,
Their checkouts fetch each file in time.
“No missing blobs!” the rabbit cheers. 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes enabling Git LFS object fetching in the sanitizer workflows.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent/sanitizer-lfs-checkout

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gitar-bot

gitar-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Enables Git LFS in the ASan coverage and TSan sanitizer workflow checkout steps to fetch the real vendored AWS SDK archive. No issues found.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@renecannao
renecannao marked this pull request as ready for review August 13, 2026 18:39
@renecannao
renecannao merged commit 96ad174 into v3.0 Aug 13, 2026
5 checks passed
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant