ci: fetch LFS objects in sanitizer workflows - #6060
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📜 Recent review details⏰ Context from checks skipped due to timeout. (1)
🔇 Additional comments (2)
📝 WalkthroughWalkthroughThe ASAN coverage and TSAN GitHub Actions workflows now enable Git LFS during repository checkout. ChangesCI Git LFS Checkout
Estimated code review effort: 1 (Trivial) | ~2 minutes Mergeability Score: ⚪ Minimal · up to This PR enables Git LFS for the two sanitizer workflow checkouts so vendored archives are fetched correctly; no actionable merge-blocking risk remains beyond normal checks. Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code Review ✅ ApprovedEnables Git LFS in the ASan coverage and TSan sanitizer workflow checkout steps to fetch the real vendored AWS SDK archive. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
|



What changed
Enable Git LFS in the pinned checkout steps used by the ASan coverage and TSan
workflow_runjobs.Root cause
PR #6048 vendors the AWS SDK archive as an LFS object. These two default-branch workflows checked out the triggering SHA without LFS, so the build received the pointer text and reported a vendored SDK checksum mismatch before any sanitizer tests ran.
Impact
Future sanitizer runs check out the real vendored archive while retaining the existing Docker-isolated build and test flow.
Validation
lfs: trueinput.git diff --checkpasses.Related: #6048
Summary by cubic
Fetch Git LFS objects in ASan coverage and TSan sanitizer workflows so builds use the real vendored AWS SDK archive. Previously these jobs checked out without LFS and saw pointer files, causing checksum mismatches; now they fetch LFS and proceed with tests.
lfs: trueon the pinnedactions/checkoutsteps in.github/workflows/CI-unit-tests-asan-coverage.ymland.github/workflows/CI-unit-tests-tsan.yml.lfs: trueappears once in each affected checkout step.Written for commit ce8aa36. Summary will update on new commits.
Summary by CodeRabbit