ci: add reusables for legacy-binlog-g1, mysql90-binlog-g1, mysql95-binlog-g1 - #6093
Conversation
…nlog-g1 Platform-side shim workflows that delegate to the existing ci-ai-gcov.yml reusable (added in PR #6089) with the per-group tap_group / infra_id. Mirrors the ci-ai-g1.yml / ci-ai-g2.yml pattern extracted in the same PR. These complete the caller/reusable pair with the CI-*-g1.yml files landed on v3.0 — without the reusables here, the new callers would invoke a non-existent @gh-actions ref and fail every run at workflow resolution time. The actual MySQL backend for each group is selected by the group's test/tap/groups/<group>/infras.lst (infra-dbdeployer-mysql57-binlog / -mysql90 / -mysql95), already wired up on v3.0. Closes #6092.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan includes up to 8 reviews per rolling hour; 7 remain after this review. 📜 Recent review details🔇 Additional comments (3)
📝 WalkthroughWalkthroughAdded reusable GitHub Actions workflows for legacy, MySQL 9.0, and MySQL 9.5 binlog group 1 CI. Each workflow accepts a trigger and delegates tests to the shared GCOV workflow. ChangesBinlog CI workflow coverage
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change adds three CI workflow entry points for existing binlog groups; no actionable merge-blocking risk remains after normal checks and review. Sequence Diagram(s)sequenceDiagram
participant GitHubActions
participant BinlogWorkflows
participant ci_ai_gcov
participant BinlogTests
GitHubActions->>BinlogWorkflows: provide trigger
BinlogWorkflows->>ci_ai_gcov: delegate tap group and infrastructure ID
ci_ai_gcov->>BinlogTests: run configured binlog tests
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code Review ✅ ApprovedAdds reusable CI workflow shims for legacy-binlog-g1, mysql90-binlog-g1, and mysql95-binlog-g1 to extend test coverage. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Important Your trial ends in 7 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more. Was this helpful? React with 👍 / 👎 | Gitar |
… is merged The v3.0 callers for legacy-binlog-g1 / mysql90-binlog-g1 / mysql95-binlog-g1 in this branch reference sysown/proxysql/.github/workflows/ci-<group>.yml@GH-Actions, which only exist on GH-Actions since PR #6093 landed. The previous CI run on this branch failed at workflow-resolution time because the reusables weren't there yet; an empty commit re-runs CI against the now-complete state.
|
1 participant
This adds the GH-Actions-branch half of CI coverage for the three binlog groups that were already registered in
test/tap/groups/groups.jsonbut had no CI workflow before PR #6086 (which addedmysql84-binlog-g1):legacy-binlog-g1— backend infra-dbdeployer-mysql57-binlogmysql90-binlog-g1— backend infra-dbdeployer-mysql90-binlogmysql95-binlog-g1— backend infra-dbdeployer-mysql95-binlogWhat this PR does
ci-ai-gcov.ymlreusable (added in PR ci: wire AI TAP coverage shards #6089) with the per-grouptap_group/infra_id. Mirrors theci-ai-g1.yml/ci-ai-g2.ymlpattern extracted in the same PR.mysqlbinlogCLI (built by the mysql-connector-c-8.4.0 build as a side effect ofmake) intotest/tap/tap/bin/BEFORE the test/deps/ deletion. Without this, themysql84-binlog-g1group fails at runtime because the binary is gone after the cache prune (see mysql84-binlog-g1 fails at runtime:test_com_binlog_dump_enables_fast_forward-tcannot find ${TEST_DEPS}/mysqlbinlog #6092). ~37 MB extra in the _test cache; the runner attest/infra/control/run-tests-isolated.bashalreadyfinds the workspace and symlinks it into${TEST_DEPS}/mysqlbinlog.Companion
The caller side lives on v3.0 in PR #6094 (branch
fix/test-deps-mysqlbinlog). This PR must land first — the v3.0 callers invokeci-<group>.yml@GH-Actions, so resolving the ref requires the files to already exist onGH-Actions. Merging the v3.0 PR before this one would red CI with "Could not find workflow reference".Issue
Closes #6092 (the first of the issue's two follow-ups; the v3.0 PR also lands the runner fallback that fixes the failing mysqbilnog lookup in mysql84-binlog-g1).
Notes
ci-ai-gcov.ymlshim rather than a dedicatedci-<group>.ymlstandalone reusable (likeci-mysql84-binlog-g1.ymlis). The shim is bit-identical to ai-g1/ai-g2 vs. mysql84-binlog-g1's standalone reusable, so the new workflows inherit the bug fixes (the codecov retry triad, the harness NULLable permissions, etc.) PR ci: wire AI TAP coverage shards #6089 brought intoci-ai-gcov.ymlwithout per-group duplication.test/tap/groups/<group>/infras.lst, already wired up on v3.0.matrix.infradbis hardcoded tomysql84inci-ai-gcov.yml, so the check name for these three workflows will readCI-AI-GCOV / tests (mysql84,genai-gcov)— a label artifact, not the actual backend. The workflow / group name in the GitHub UI is the source of truth. Worth parameterizingmatrix.infradbin a follow-up if reviewers want cosmetic accuracy.