Update Xtensa per openocd patch. Remove autoconf generated files.#3
Open
rfoos wants to merge 1 commit intosysprogs:masterfrom
Open
Update Xtensa per openocd patch. Remove autoconf generated files.#3rfoos wants to merge 1 commit intosysprogs:masterfrom
rfoos wants to merge 1 commit intosysprogs:masterfrom
Conversation
Added tools from openocd. Added bootstrap and submodules (.gitmodules) Removed generated Makefile.in, etc. Added README required by autoconf. Merged xtensa changes from Thomas Schmid patch, and applied fixes per Andreas comment. http://openocd.zylin.com/#/c/3348/
Owner
|
Thanks for the pull request. Looks great except for one small thing: could you please get the autoconf-generated files back? The entire autoconf/automake system is a big mess on MinGW, so requiring the Windows users to get it makes the build a lot more complicated. We know it's not the right way in terms of autoconf philosophy, but it saves a huge effort for Windows users to have those files checked in. |
Author
|
I'll put them back. It was a small pain to have conflicts with different versions of autoconf and Makefile.in's. I've switched to Msys2. It handles autoconf, and tools install/update with pacman. I think you'll find this eliminates your Makefile.in requirement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bulk of this change was to remove the autoconf generated files from git, and set executable permissions on some files for linux.
From the main openocd tree, the tools directory was added.
The xtensa target was modified per comments on the openocd tree.
A board, olimex_esp8266.cfg, was added to pull together the correct interface and target files.
It is building and running on Ubuntu 16.04.
Cheers,
Rick
Added tools from openocd.
Added bootstrap and submodules (.gitmodules)
Removed generated Makefile.in, etc.
Added README required by autoconf.
Merged xtensa changes from Thomas Schmid patch,
and applied fixes per Andreas comment.
http://openocd.zylin.com/#/c/3348/