chore: regenerate models from upstream schemas#124
Conversation
There was a problem hiding this comment.
Code Review
This is an automated regeneration of extension models from upstream provider schemas (AWS CloudFormation, GCP Discovery, DigitalOcean OpenAPI). All 31 changed files are under model/ with consistent auto-generated headers, CalVer version bumps, and proper upgrade entries.
Blocking Issues
None.
Suggestions
-
model/aws/datazone/extensions/models/user_profile.ts— non-optional fields in nestedStateSchema
The two new fields added insideDetails.Iamare not marked.optional():Iam: z.object({ Arn: z.string(), SessionName: z.string(), // NEW — required GroupProfileId: z.string(), // NEW — required }),
If the AWS API doesn't always return
SessionName/GroupProfileId(e.g. for non-session IAM profiles), Zod will reject the parse andsync/getwill throw. Worth confirming the upstream CloudFormation schema marks these as always-present; if not, they should be.optional(). -
model/aws/chime/README.md— now documents onlyapp_instance_bot
The README was regenerated to replace allapp_instancereferences withapp_instance_bot, butapp_instance.tsstill exists in the same package. The README is now misleading for users of theapp_instancemodel. If the README generator is supposed to document a single model per run, this is a codegen-tooling gap worth tracking. -
GCP stale release notes removal — Several GCP manifests (accesscontextmanager, bigquerydatapolicy, bigtableadmin, cloudsearch, compute, networkservices, pubsub) have their previous
releaseNotesblocks removed with no replacement. This appears to be intentional cleanup (each run only surfaces the current version's notes), but it means those manifests now carry no notes at all. Consistent behaviour across providers would be clearer.
There was a problem hiding this comment.
Code Review
This is an automated regeneration of extension models from upstream provider schemas (AWS CloudFormation, GCP Discovery, DigitalOcean OpenAPI). All 31 changed files are under model/ with consistent auto-generated headers, CalVer version bumps, and proper upgrade entries.
Blocking Issues
None.
Suggestions
-
model/aws/datazone/extensions/models/user_profile.ts— non-optional fields in nested StateSchema
Two new fields added insideDetails.Iamare not marked.optional():SessionNameandGroupProfileId. If the AWS API does not always return these (e.g. for non-session IAM profiles), Zod will reject the parse andsync/getwill throw. Worth confirming the upstream CloudFormation schema marks these as always-present; if not, they should be.optional(). -
model/aws/chime/README.md— now documents only app_instance_bot
The README was regenerated replacing allapp_instancereferences withapp_instance_bot, butapp_instance.tsstill exists in the package. The README is now misleading forapp_instanceusers. If the README generator documents a single model per run, this is a codegen tooling gap worth tracking. -
GCP stale release notes removal — Several GCP manifests (accesscontextmanager, bigquerydatapolicy, bigtableadmin, cloudsearch, compute, networkservices, pubsub) have their previous
releaseNotesblocks removed with no replacement. This appears intentional (each run surfaces only the current version's notes), but it means those manifests now carry no notes at all. Consistent behaviour across providers would be clearer.
Summary
Automated regeneration of extension models from upstream provider schemas.
Changes
Schema Sources
Review Notes
model/are auto-generated — review themanifest.yamldiffs for version changes