chore: regenerate models from upstream schemas#125
Conversation
There was a problem hiding this comment.
Code Review
Blocking Issues
-
Model files contain content changes beyond version/upgrade entries with no corresponding
codegen/changes.All 41 changed files are under
model/(auto-generated), yetcodegen/has zero changes. Per CLAUDE.md and the project's review policy, model files may change without codegen changes only in two legitimate cases:- Codegen regeneration — requires
codegen/to also change (pipeline or schema code modified) - Version-only bumps via
bump-versions— only version, upgrades, and manifest entries change
This PR's model changes go well beyond version/upgrade entries and include real content diffs:
- New file:
model/aws/elasticache/extensions/models/cache_cluster.ts(433 lines) - New fields:
UseClientCertificateOCSPEndpoint(cloudfront/trust_store),DatabaseInstallationFiles(rds/custom_dbengine_version),defaultUriDisabled(gcp/run/instances),postgresHomogeneousConfig(gcp/datamigration/migrationjobs) - Removed method:
update_memory_layer(~44 lines) fromgcp/bigtableadmin/instances_clusters - Enum changes:
passthroughadded to cloudfront distribution mTLS mode;POSTGRES_19andPROJECT_ABUSEadded to sqladmin instances - Regex change: IAM role ARN pattern in
model/aws/eks/addon.ts - Description wording changes across multiple dataproc, logging, datalineage, and accesscontextmanager models
If this was produced by running the codegen pipeline against new upstream schemas, please include the corresponding codegen run evidence or ensure the CI automation commits any affected
codegen/artifacts (e.g. fetched schema snapshots, deno.lock updates inside codegen/) alongside the regenerated model output. Without that, these look like hand-edits to generated files. - Codegen regeneration — requires
Suggestions
- The
releaseNotesremoval from manifests likebedrockagentcore,chime,datazone,deadline,firestore,interconnect,ondemandscanning,storagebatchoperations, anddigitalocean(where no model.tsfiles changed) is correct behavior — removing stale notes from a prior run — but it's worth verifying the codegen pipeline intentionally clearsreleaseNoteswhen there are no content changes in a given cycle.
Summary
Automated regeneration of extension models from upstream provider schemas.
Changes
Schema Sources
Review Notes
model/are auto-generated — review themanifest.yamldiffs for version changes