Conversation
There was a problem hiding this comment.
Code Review
Blocking Issues
-
Model files changed without corresponding codegen/ changes. This PR modifies
.tsmodel files undermodel/aws/andmodel/gcp/(e.g.cloudfront/extensions/models/distribution.ts,route53resolver/extensions/models/resolver_endpoint.ts,sqladmin/extensions/models/instances.ts, and 30+ others) with content changes beyond version/upgrade entries — new fields, enum additions, deprecation removals, descriptor updates. However, no files undercodegen/are changed.Per the review policy, model files may change without codegen changes only in two legitimate cases:
- Codegen regeneration (codegen/ must also change)
- Version bumps via
bump-versionsscript (only version, upgrades, and manifest entries change)
Neither case applies here: the changes span
.tsfiles (not just manifests), andcodegen/is untouched. This matches the blocking pattern: hand-edited generated code.If this is a genuine schema-driven regeneration, please include the codegen run evidence — either commit the updated
codegen/artifacts, or confirm via CI output that the pipeline was executed and these.tsfiles are its exact output (and that running the pipeline a second time produces no further diff).
Suggestions
- None.
Summary
Automated regeneration of extension models from upstream provider schemas.
Changes
Schema Sources
Review Notes
model/are auto-generated — review themanifest.yamldiffs for version changes