refactor(domain): lift UnifiedDataRepository port into domain layer (swamp-club#229)

integration/ddd_layer_rules_test.ts

@@ -69,9 +69,7 @@ function isTracingImport(filePath: string, importPath: string): boolean {
 // If someone fixes a violation, the count decreases and the test still passes.
 // If someone adds a new violation, the count increases and the test fails.
 //
-// Tracked refactor (data services → domain-side ports): swamp-club#229.
-//
-// Issue #223 (W1b extension catalog rearchitecture) added 4 new
+// Issue #223 (W1b extension catalog rearchitecture) added 4 transitional
 // domain→infrastructure imports:
 //   - src/domain/extensions/bundle_location.ts → canonicalizePath
 //   - src/domain/extensions/source_location.ts → canonicalizePath
@@ -83,9 +81,8 @@ function isTracingImport(filePath: string, importPath: string): boolean {
 // references for I-Repo-1 cross-aggregate uniqueness. Both are accepted
 // as transitional ports — the canonicalizer should move to a shared
 // path-utility module (W3 territory) and ExtensionKind should hoist to
-// the domain layer when the catalog gets fully replaced (W4). Until
-// then the violations are bounded and the ratchet rises by 4 (27 + 4).
-const KNOWN_DOMAIN_INFRA_VIOLATIONS = 31;
+// the domain layer when the catalog gets fully replaced (W4).
+const KNOWN_DOMAIN_INFRA_VIOLATIONS = 22;
 
 Deno.test(
   "domain layer must not add new infrastructure imports (ratchet)",

src/domain/data/data_access_service.ts

@@ -19,7 +19,7 @@
 
 import type { DefinitionRepository } from "../definitions/repositories.ts";
 import type { ModelType } from "../models/model_type.ts";
-import type { UnifiedDataRepository } from "../../infrastructure/persistence/unified_data_repository.ts";
+import type { UnifiedDataRepository } from "./repositories.ts";
 import type { VaultService } from "../vaults/vault_service.ts";
 import type { SecretRedactor } from "../secrets/mod.ts";
 import type { Data } from "./data.ts";

src/domain/data/data_access_service_test.ts

@@ -24,7 +24,7 @@ import { ModelType } from "../models/model_type.ts";
 import { Definition } from "../definitions/definition.ts";
 import { computeDefinitionHash } from "../models/model_output.ts";
 import type { DefinitionRepository } from "../definitions/repositories.ts";
-import type { UnifiedDataRepository } from "../../infrastructure/persistence/unified_data_repository.ts";
+import type { UnifiedDataRepository } from "./repositories.ts";
 import type { VaultService } from "../vaults/vault_service.ts";
 
 // Import models barrel to trigger self-registration

src/domain/data/data_delete_service.ts

@@ -17,8 +17,8 @@
 // You should have received a copy of the GNU Affero General Public License
 // along with Swamp.  If not, see <https://www.gnu.org/licenses/>.
 
-import type { UnifiedDataRepository } from "../../infrastructure/persistence/unified_data_repository.ts";
-import type { YamlDefinitionRepository } from "../../infrastructure/persistence/yaml_definition_repository.ts";
+import type { UnifiedDataRepository } from "./repositories.ts";
+import type { DefinitionRepository } from "../definitions/repositories.ts";
 import { findDefinitionByIdOrName } from "../models/model_lookup.ts";
 
 /**
@@ -60,7 +60,7 @@ export interface DeletePreview {
 export class DataDeleteService {
   constructor(
     private readonly dataRepo: UnifiedDataRepository,
-    private readonly definitionRepo: YamlDefinitionRepository,
+    private readonly definitionRepo: DefinitionRepository,
   ) {}
 
   async delete(

src/domain/data/data_lifecycle_service.ts

@@ -21,7 +21,7 @@ import { getLogger } from "@logtape/logtape";
 import type { Data } from "./data.ts";
 import type { Lifetime } from "./data_metadata.ts";
 import { parseDataDuration } from "./duration.ts";
-import type { UnifiedDataRepository } from "../../infrastructure/persistence/unified_data_repository.ts";
+import type { UnifiedDataRepository } from "./repositories.ts";
 import type { WorkflowRunRepository } from "../workflows/repositories.ts";
 import type { ModelType } from "../models/model_type.ts";
 import {

src/domain/data/data_query_service.ts

@@ -23,7 +23,7 @@ import type {
   CatalogRow,
   CatalogStore,
 } from "../../infrastructure/persistence/catalog_store.ts";
-import type { UnifiedDataRepository } from "../../infrastructure/persistence/unified_data_repository.ts";
+import type { UnifiedDataRepository } from "./repositories.ts";
 import type { DataRecord } from "./data_record.ts";
 import {
   type ASTNode,

src/domain/data/data_record_mapper.ts

@@ -21,7 +21,7 @@ import type { CatalogRow } from "../../infrastructure/persistence/catalog_store.
 import type { DataRecord, FileDataRecord } from "./data_record.ts";
 import type { Data } from "./data.ts";
 import { ModelType } from "../models/model_type.ts";
-import type { UnifiedDataRepository } from "../../infrastructure/persistence/unified_data_repository.ts";
+import type { UnifiedDataRepository } from "./repositories.ts";
 import type { VaultService } from "../vaults/vault_service.ts";
 import type { SecretRedactor } from "../secrets/mod.ts";
 import type { DataHandle } from "../models/model.ts";

src/domain/data/data_record_mapper_test.ts

@@ -20,7 +20,7 @@
 import { assertEquals } from "@std/assert";
 import { fromData, fromRow } from "./data_record_mapper.ts";
 import type { CatalogRow } from "../../infrastructure/persistence/catalog_store.ts";
-import type { UnifiedDataRepository } from "../../infrastructure/persistence/unified_data_repository.ts";
+import type { UnifiedDataRepository } from "./repositories.ts";
 import { Data } from "./data.ts";
 import { ModelType } from "../models/model_type.ts";
 

src/domain/data/data_rename_service.ts

@@ -18,8 +18,8 @@
 // along with Swamp.  If not, see <https://www.gnu.org/licenses/>.
 
 import { DataMetadataSchema } from "./data_metadata.ts";
-import type { UnifiedDataRepository } from "../../infrastructure/persistence/unified_data_repository.ts";
-import type { YamlDefinitionRepository } from "../../infrastructure/persistence/yaml_definition_repository.ts";
+import type { UnifiedDataRepository } from "./repositories.ts";
+import type { DefinitionRepository } from "../definitions/repositories.ts";
 import { findDefinitionByIdOrName } from "../models/model_lookup.ts";
 
 /**
@@ -44,7 +44,7 @@ export interface RenameResult {
 export class DataRenameService {
   constructor(
     private readonly dataRepo: UnifiedDataRepository,
-    private readonly definitionRepo: YamlDefinitionRepository,
+    private readonly definitionRepo: DefinitionRepository,
   ) {}
 
   /**