fix(repo): narrow Claude gitignore entry so .claude/skills/ is not ignored (swamp-club#250)

[stack72]

Summary

• The managed .gitignore section wrote .claude/ (entire directory) for Claude repos, but all other tools only ignored their specific skills subdirectory (e.g. .cursor/skills/, .kiro/skills/)
• This caused .claude/skills/ to be gitignored, so extension authors could not commit skill source files — making swamp extension push fail from any fresh CI/CD clone that didn't already have skills installed locally
• Replace the broad .claude/ entry with four specific lines that mirror what the swamp repo's own .gitignore already does: .claude/worktrees/, .claude/settings.local.json, .claude/scheduled_tasks.lock, .claude/scheduled_tasks.json

.claude/skills/ is now untracked by the managed section. Extension authors can commit skill sources, swamp extension push packages them correctly, and swamp extension pull installs them to .claude/skills/<name>/ where Claude Code loads them — unchanged.

Test Plan

• Updated repo_service_test.ts: replaced assertStringIncludes(content, ".claude/") substring assertions with precise checks for each specific entry, added assertEquals(content.split("\n").includes(".claude/"), false) to confirm the broad ignore is absent, added a dedicated Claude block verifying all four entries and that .claude/skills/ is not blocked
• 110 tests pass across repo_service_test.ts and integration/cli_test.ts
• deno check, deno lint, deno fmt all clean

🤖 Generated with Claude Code

[github-actions]

Code Review

Clean, well-motivated bug fix. The four specific .claude/ entries exactly mirror the swamp repo's own .gitignore (lines 17, 21–23), and the legacy migration pattern at repo_service.ts:1051 correctly retains .claude/ recognition for migrating old gitignore formats.

Blocking Issues

None.

Suggestions

None — test coverage is thorough (positive assertions for all four entries, negative assertion for the broad .claude/ pattern, tool-switch cleanup verification, and a dedicated Claude-specific test block). The change is minimal and well-scoped.

[github-actions]

Adversarial Review

Critical / High

None.

Medium

1. src/domain/repo/repo_service_test.ts:1072-1073 — Tool-switch test only verifies 2 of 4 Claude entries are removed. The "replaces managed section on tool switch" test asserts that .claude/worktrees/ and .claude/settings.local.json are absent after switching to cursor, but does not verify .claude/scheduled_tasks.lock or .claude/scheduled_tasks.json are also gone. In practice this is fine because replaceManagedSection atomically replaces the entire block between markers, so partial removal is impossible — but the test doesn't fully prove the contract for the new four-entry set. Not blocking since the mechanism is sound.

Low

1. src/domain/repo/repo_service.ts:75 — Future .claude/ files created by Claude Code won't be gitignored. The old .claude/ glob caught everything; the new four entries are specific. If Claude Code adds new ephemeral files (e.g. .claude/todos.json, .claude/cache/), they'll appear as untracked until swamp adds them. This is the intended tradeoff (unblock .claude/skills/), and the entries match the repo's own .gitignore, so this is a conscious design decision rather than an oversight.

Verdict

PASS — Minimal, well-scoped change (1 production line, thorough test updates). The four specific ignore entries match the repo's own .gitignore. Legacy migration correctly recognizes the old .claude/ pattern (line 1051) to transition existing repos. The buildGitignoreSection / replaceManagedSection logic handles all code paths (create, update, migrate, tool-switch) and tests cover each.