refactor(tests): move root-level test projects to correct subdirectories#490
refactor(tests): move root-level test projects to correct subdirectories#490sytone wants to merge 1 commit into
Conversation
Farnsworth Review — PR #490CI: ✅ All checks passing (build-and-test, CodeQL, TruffleHog, patterns, deps) Test coverage: Build and tests pass post-refactor — the change is structural, no new test logic needed. All existing tests continue to pass. Spec completeness vs #329: 6 test projects relocated into proper subdirs matching Design notes: LGTM. Ready to merge. |
|
CI: All checks passing LGTM - ready to merge. |
|
CI: ✅ All checks passing LGTM — ready to merge. |
sytone
left a comment
There was a problem hiding this comment.
Farnsworth Review — PR #490
CI: ✅ All checks passing
Merge conflicts: ✅ Clean (MERGEABLE)
Conventional commit title: ✅ refactor(tests): move root-level test projects to correct subdirectories
Test coverage:
- ✅ All tests pass after relocation (build clean)
- 7 csproj ProjectReference paths fixed
- BotNexus.slnx updated
Spec completeness vs #329: 6 test projects correctly relocated. Remaining scope (stub projects, MockMcpTransport.cs) deferred — appropriate.
LGTM. Ready to merge.
|
Closing as part of a planned hard-reset of the in-flight branch set so the new domain-model refactor can land on a clean trunk. Audit verdict: keep Rationale: Pure test-org refactor. The new plan (in session state) reshapes core types: Citizen (User+Agent union), Vogen-generated value objects, ThreadId removed in favour of composite ChannelAddress, mark-not-delete compaction, centralised If this work is still wanted, refile as a new issue/PR against the post-refactor contracts. |
Moves 6 root-level test projects from
tests/into the correct subdirectories that mirror thesrc/layout, as specified in #329.Changes
BotNexus.CodingAgent.Tests→tests/examples/BotNexus.Conversation.Tests→tests/gateway/BotNexus.E2E.Tests→tests/e2e/BotNexus.Gateway.Conversation.Tests→tests/gateway/BotNexus.Integration.Tests→tests/integration/BotNexus.Providers.Conformance.Tests→tests/agent/ProjectReferencepaths (3 csproj files + 4 provider test csproj files referencing conformance tests)BotNexus.slnxsolution folders to match new locationsSystemPromptBuilderSnapshotTests.csWhat's not included
BotNexus.Gateway.Abstractions.Tests, etc.) — left for follow-uptests/BotNexus.Testing/MockMcpTransport.csresolution — left for follow-upAll existing tests pass (build: 0 errors, 0 warnings).
Closes #329