Skip to content

refactor(tests): move root-level test projects to correct subdirectories#490

Closed
sytone wants to merge 1 commit into
mainfrom
refactor/test-directory-layout
Closed

refactor(tests): move root-level test projects to correct subdirectories#490
sytone wants to merge 1 commit into
mainfrom
refactor/test-directory-layout

Conversation

@sytone
Copy link
Copy Markdown
Owner

@sytone sytone commented May 22, 2026

Moves 6 root-level test projects from tests/ into the correct subdirectories that mirror the src/ layout, as specified in #329.

Changes

  • BotNexus.CodingAgent.Teststests/examples/
  • BotNexus.Conversation.Teststests/gateway/
  • BotNexus.E2E.Teststests/e2e/
  • BotNexus.Gateway.Conversation.Teststests/gateway/
  • BotNexus.Integration.Teststests/integration/
  • BotNexus.Providers.Conformance.Teststests/agent/
  • Updated all relative ProjectReference paths (3 csproj files + 4 provider test csproj files referencing conformance tests)
  • Updated BotNexus.slnx solution folders to match new locations
  • Updated snapshot path in SystemPromptBuilderSnapshotTests.cs

What's not included

  • Stub test projects for missing coverage (BotNexus.Gateway.Abstractions.Tests, etc.) — left for follow-up
  • tests/BotNexus.Testing/MockMcpTransport.cs resolution — left for follow-up

All existing tests pass (build: 0 errors, 0 warnings).

Closes #329

@sytone
Copy link
Copy Markdown
Owner Author

sytone commented May 22, 2026

Farnsworth Review — PR #490

CI: ✅ All checks passing (build-and-test, CodeQL, TruffleHog, patterns, deps)
Merge conflicts: ✅ CLEAN / MERGEABLE
Conventional commit title: refactor(tests): move root-level test projects to correct subdirectories

Test coverage: Build and tests pass post-refactor — the change is structural, no new test logic needed. All existing tests continue to pass.

Spec completeness vs #329: 6 test projects relocated into proper subdirs matching src/ layout. BotNexus.slnx updated. ProjectReference paths fixed in 7 csproj files. Remaining scope (stub projects, MockMcpTransport.cs) explicitly noted as follow-up — acceptable.

Design notes:
Keeping test project structure aligned with src/ layout is correct housekeeping — makes cross-project navigation predictable.
Incrementally scoped (6 projects now, stubs later) is pragmatic.

LGTM. Ready to merge.

@sytone
Copy link
Copy Markdown
Owner Author

sytone commented May 22, 2026

CI: All checks passing
Merge conflicts: Clean / MERGEABLE
Commit title: Conventional commit format correct (refactor type, tests scope)
Coverage: No new tests needed - pure layout refactor, existing tests relocated
Spec completeness: Closes #329 - 6 test projects relocated to correct subdirs, 7 ProjectReference paths fixed, BotNexus.slnx updated. Stub projects and MockMcpTransport.cs noted as follow-up.

LGTM - ready to merge.

@sytone
Copy link
Copy Markdown
Owner Author

sytone commented May 22, 2026

CI: ✅ All checks passing
Merge: CLEAN — no conflicts
Commit title: refactor(tests): move root-level test projects to correct subdirectories ✅ Conventional commit
Coverage: Structural refactor — all existing tests pass post-move
Spec completeness: Partial #329 — 6 test projects relocated, ProjectReferences + slnx fixed; stub projects/MockMcpTransport left as follow-up

LGTM — ready to merge.

Copy link
Copy Markdown
Owner Author

@sytone sytone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Farnsworth Review — PR #490

CI: ✅ All checks passing
Merge conflicts: ✅ Clean (MERGEABLE)
Conventional commit title:refactor(tests): move root-level test projects to correct subdirectories

Test coverage:

  • ✅ All tests pass after relocation (build clean)
  • 7 csproj ProjectReference paths fixed
  • BotNexus.slnx updated

Spec completeness vs #329: 6 test projects correctly relocated. Remaining scope (stub projects, MockMcpTransport.cs) deferred — appropriate.

LGTM. Ready to merge.

@sytone
Copy link
Copy Markdown
Owner Author

sytone commented May 22, 2026

Closing as part of a planned hard-reset of the in-flight branch set so the new domain-model refactor can land on a clean trunk.

Audit verdict: keep

Rationale: Pure test-org refactor.

The new plan (in session state) reshapes core types: Citizen (User+Agent union), Vogen-generated value objects, ThreadId removed in favour of composite ChannelAddress, mark-not-delete compaction, centralised SessionContextProjector, single-path routing. Many in-flight branches touch contracts that are about to change — rebasing later would be more work than rebuilding on the new shape.

If this work is still wanted, refile as a new issue/PR against the post-refactor contracts.

@sytone sytone closed this May 22, 2026
@sytone sytone deleted the refactor/test-directory-layout branch May 22, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Tests] Revamp testing structure to mirror src directory layout

1 participant