feat(portal): add conversation bindings management panel#493
Conversation
|
CI: All checks passing LGTM - ready to merge. |
|
CI: ✅ All checks passing LGTM — ready to merge. |
sytone
left a comment
There was a problem hiding this comment.
Farnsworth Review — PR #493
CI: ✅ All checks passing
Merge conflicts: ✅ Clean (MERGEABLE)
Conventional commit title: ✅ feat(portal): add conversation bindings management panel
Test coverage:
- ✅ 8 bunit tests (view, add, remove, error handling)
- Full suite passes clean
Spec completeness vs #140 (partial): Binding view/add/remove correctly implemented. Portal UI component satisfies the partial scope. Move-binding endpoint is in PR #488.
LGTM. Ready to merge.
|
Closing as part of a planned hard-reset of the in-flight branch set so the new domain-model refactor can land on a clean trunk. Audit verdict: close Rationale: UI surface for ChannelBinding which changes in Phase 6b. Rebuild on new shape. The new plan (in session state) reshapes core types: Citizen (User+Agent union), Vogen-generated value objects, ThreadId removed in favour of composite ChannelAddress, mark-not-delete compaction, centralised If this work is still wanted, refile as a new issue/PR against the post-refactor contracts. |
Closes #140
Changes
ConversationBindingsPanel.razorNew Blazor component at
Components/ConversationBindingsPanel.razor:aria-label,aria-required,role=alertdialog,role=alert,role=statusTests (8 tests)
Shows_loading_spinner_initiallyShows_empty_state_when_no_bindingsDisplays_bindings_in_tableShows_add_binding_form_when_add_button_clickedCancel_add_form_hides_formDelete_button_shows_confirmation_dialogShows_error_when_load_failsAdd_binding_form_validation_shows_errorsNote: This PR covers the portal UI portion of #140. The REST API (POST /bindings, DELETE /bindings/{id}, POST /bindings/{id}/move) is already implemented and merged in PR #488. The
moveUI is a follow-up.