feat(gateway): add botnexus_admin tool for safe platform management#499
feat(gateway): add botnexus_admin tool for safe platform management#499sytone wants to merge 1 commit into
Conversation
Agents can now manage agents via the botnexus_admin tool instead of writing config.json directly. Closes #370
|
CI: ✅ All checks passing LGTM — ready to merge. |
sytone
left a comment
There was a problem hiding this comment.
Farnsworth Review — PR #499
CI: ✅ All checks passing (build-and-test, CodeQL, Security Scan)
Merge conflicts: ✅ Clean (MERGEABLE)
Conventional commit title: ✅ feat(gateway): add botnexus_admin tool for safe platform management
Test coverage:
- ✅ All 6 actions covered (get_config, list_agents, get_platform_status, create_agent, update_agent, delete_agent)
- ✅ Authorization/opt-in via toolIds
- ✅ Mutations via IAgentRegistry + IAgentConfigurationWriter (no direct file access)
- 15 new tests; 1651/1651 pass
Spec completeness vs #370: Fully satisfies acceptance criteria. Using registry + writer abstractions rather than direct file access is the right architectural choice.
LGTM. Ready to merge.
|
Closing as part of a planned hard-reset of the in-flight branch set so the new domain-model refactor can land on a clean trunk. Audit verdict: keep Rationale: Tool-layer addition; orthogonal. The new plan (in session state) reshapes core types: Citizen (User+Agent union), Vogen-generated value objects, ThreadId removed in favour of composite ChannelAddress, mark-not-delete compaction, centralised If this work is still wanted, refile as a new issue/PR against the post-refactor contracts. |
Closes #370
Changes
Adds a new botnexus_admin IAgentTool that provides a safe, validated gateway management API for agents.
Why
Agents were writing directly to config.json via write/edit tools. This caused production incidents. This tool routes all mutations through the Gateway's own validated code paths.
Operations
Implementation
Not in this PR (follow-up work)