Conversation
… names Enum values named `index` or `values` now get a `$` prefix to avoid conflicts with Dart's built-in Enum.index and Enum.values. This only applies to enum values — class properties named `index` remain valid. Also fixes normalizeSingle to spell out purely numeric property names (e.g. `600` → `sixHundred`) regardless of the preserveNumbers flag, matching the existing behavior for enum values.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
==========================
==========================
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
indexorvaluesnow get a$prefix to avoid conflicts with Dart's built-inEnum.indexandEnum.values(fixes 7 compile errors in the Cloudflare spec)normalizeSinglenow spells out purely numeric property names (e.g.600→sixHundred) regardless of thepreserveNumbersflag, matching the existing enum value behaviorTest plan
index,INDEX,Index→$indexvalues,VALUES→$valuesreindex,indexing,INDEX_TYPEpass through unescapednormalizeSingle('index')remainsindex(valid for class properties)