Skip to content

adds if block given check #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andykallhoff wants to merge 1 commit into
base: master
Choose a base branch
from
Open

adds if block given check #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/volie/client/resource.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,13 @@ def define_rest_actions(resource_name, opts = {})
end

define_singleton_method :list_all_the_things_where do |options = {}, &block|
list_all_the_things(options, &block)
if block_given?
list_all_the_things(options, &block)
else
list = []
list_all_the_things(options) { |batch| list.push(*batch) }
list.flatten
end
end
end

Expand Down
2 changes: 1 addition & 1 deletion test/volie/client/resource_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ def test_define_rest_actions_defines_rest_class_methods
assert Resource.methods.include?(:find)
refute Resource.methods.include?(:create)
Resource.define_rest_actions(:test)
%i[list create find].each do |method|
%i[list create find list_all_the_things list_all_the_things_where].each do |method|
assert Resource.methods.include?(method)
end
end
Expand Down