fix(frontend): simplify token validation logic and improve test cover…#686
Merged
fix(frontend): simplify token validation logic and improve test cover…#686
Conversation
…age for expiration and clock skew scenarios
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies frontend JWT token validation by removing client-side iat (“issued at”) checks (to better tolerate client/server clock skew) and updates unit tests to reflect the new behavior.
Changes:
- Removed
TOKEN_NOT_YET_VALIDfailure cause and theiat-based “issued in the future” invalidation logic. - Kept expiration (
exp) validation with clock tolerance and warning behavior. - Updated
isTokenValidtests to cover expired tokens and future-iat(clock skew) tokens.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
frontend-new/src/auth/services/Authentication.service.ts |
Removes iat-based validation and the associated failure cause from token validation. |
frontend-new/src/auth/services/Authentication.service.test.ts |
Reworks timing-related tests to assert expired tokens fail and future-iat tokens pass. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…age for expiration and clock skew scenarios