style: re-sync test scaffolding to canonical template (post-#36)

[tablackburn]

Summary

Re-syncs this repo's inherited test scaffolding to the current canonical template — specifically PowerShellModuleTemplate#36, which scoped the named-parameter rule after this branch was first opened.

Background: the rule changed under us

Template PR	Date	Effect
#23	2026-05-10	Named parameters everywhere + validators
this PR opened	2026-05-12	Applied #23's "name everything" style
#36	2026-05-27	Scoped it back: name parameters only on calls passing two or more arguments (a trailing switch counts); single-argument calls stay positional

#36 explicitly names this PR as a consumer to re-sync. This revision does that.

Changes

File	Result vs. upstream main
tests/MetaFixers.psm1	Byte-identical to upstream
tests/Meta.tests.ps1	Byte-identical to upstream
tests/Help.tests.ps1	Matches upstream except this repo's local divergences (the Set-BuildEnvironment bootstrap, the FilterOutCommonParameters comment-based help, and the mandatory-value note)

What went back to positional (single-argument calls)

• Help.tests.ps1: Import-PowerShellDataFile, Test-Path, Import-Module, Get-Help, global:FilterOutCommonParameters
• Meta.tests.ps1: Import-Module
• MetaFixers.psm1: the Test-FileUnicode call inside Get-UnicodeFilesList

This includes pre-existing over-naming the branch carried beyond the original style sweep (e.g. Get-Help -Name, global:FilterOutCommonParameters -Parameters), so the files are now genuinely canonical rather than "the old sweep minus its mistakes."

What stays named (intentionally)

• 2+ argument calls — Split-Path -Path … -Parent, Join-Path -Path … -ChildPath …, Get-Content -Path … -Raw (a trailing switch counts as an argument).
• The four validators — [ValidateNotNull()] / [ValidateNotNullOrEmpty()] in MetaFixers.psm1. Added by template feat: add extended media details to Search-PatMedia output #23, not reverted by fix: Validate PSScriptAnalyzer availability and harden WhatIf tests #36.
• Comment-based-help .EXAMPLE calls — left named for teaching clarity, matching fix: Validate PSScriptAnalyzer availability and harden WhatIf tests #36.

The $parameterNames → $commandParameterNames fix from the original version of this PR is no longer in the diff: it has since landed on main independently (via #60).

Behavior

Unchanged — every reverted call's positional binding is equivalent to the named form.

Test plan

• All three files parse with no syntax errors
• PSScriptAnalyzer: clean on all three files (also fixes a pre-existing PSUseBOMForUnicodeEncodedFile warning on Help.tests.ps1 by replacing two em-dashes in a comment with ASCII hyphens)
• CI passes on Linux / macOS / Windows runners

🤖 Generated with Claude Code

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds parameter validation to test helper cmdlets, changes test callers to use explicit parameters, and refines Help test setup to compute build paths from PSScriptRoot parent, guard type-folder recursion, and simplify module unloading.

Changes

Test Infrastructure Robustness

Layer / File(s)	Summary
Test helper parameter validation tests/MetaFixers.psm1	ConvertTo-UTF8 and ConvertTo-SpaceIndentation add [ValidateNotNull()] to FileInfo; Get-TextFilesList and Get-UnicodeFilesList add [ValidateNotNullOrEmpty()] to Root; Get-UnicodeFilesList calls Test-FileUnicode -FileInfo $_.
Help test environment initialization tests/Help.tests.ps1	Set-BuildEnvironment now computes path with Split-Path -Path $PSScriptRoot -Parent in BeforeDiscovery and BeforeAll; when BHBuildOutput is unset, $projectRoot is derived from that parent, $sourceManifest is located at "$Env:BHProjectName/$Env:BHProjectName.psd1", ModuleVersion is read, and BHBuildOutput set to Output/<ModuleName>/<ModuleVersion>; custom type enumeration guards with Test-Path; module removal uses Get-Module -Name.
Test caller updates for helper compatibility tests/Meta.tests.ps1, tests/Help.tests.ps1	Get-TextFilesList is invoked with explicit -Root $projectRoot; tab-detection uses Select-String -Pattern "t"; help-parameter assertion verifies membership in $commandParameterNames`.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related issues

• style: enforce quoted literals, named parameters, and parameter validation SrrDBAutomationToolkit#16: Implements the parameter-validation and named-parameter style rules discussed in the issue.
• style: enforce quoted literals, named parameters, and parameter validation #50: Changes align with the requested named-parameter and validator updates described there.
• style: enforce quoted literals, named parameters, and parameter validation ScheduledTasksManager#35: Introduces named-parameter usage and validation attributes consistent with that issue's style guidance.

Poem

🐰 Hop, hop, the tests refine their art,

Params guarded close, no nulls to start,
Paths computed neat from PSScriptRoot's tree,
Tabs found by pattern, explicit as can be,
A little rabbit clap for robust TDD!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title accurately summarizes the main objective: aligning test scaffolding with the canonical template through style rule application, with reference to the preceding PR that established those rules.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch style/align-test-scaffolding-with-template

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

Aligns this repository’s inherited test scaffolding with the canonical PowerShellModuleTemplate style rules (named parameters for multi-arg cmdlets, mandatory-parameter validators), and fixes a stale variable reference that previously made part of the help-parameter verification effectively a no-op.

Changes:

• Standardize named-parameter usage across Help/Meta tests (e.g., Split-Path, Join-Path, Get-Module, Get-Content, Select-String).
• Add parameter validators in tests/MetaFixers.psm1 for mandatory parameters ([ValidateNotNull()], [ValidateNotNullOrEmpty()]).
• Fix $parameterNames → $commandParameterNames in the help tests so the “extra help parameters” check actually evaluates.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
tests/Help.tests.ps1	Uses named parameters for several cmdlet calls and fixes a stale variable reference so the relevant Context block is no longer a no-op.
tests/Meta.tests.ps1	Applies named parameters to calls into MetaFixers and standard cmdlets (Get-Content, Select-String).
tests/MetaFixers.psm1	Adds validators for mandatory params and updates Test-FileUnicode invocation to use the explicit -FileInfo parameter.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.