ci(release): make UpdateReleaseNotes manifest write non-fatal#32
Conversation
Backports the guard added during the PlexAutomationToolkit rollout review: the task is documented as non-fatal, but the final Update-ModuleManifest -ErrorAction Stop was unguarded, so a failure (e.g. missing built manifest) would hard-fail Publish. Add a Test-Path check for the built manifest and wrap the update in try/catch that warns and leaves the existing ReleaseNotes in place, keeping the release unblocked as intended. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR adds defensive error handling to the ChangesUpdateReleaseNotes task robustness
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Makes the UpdateReleaseNotes psake task fully non-fatal by ensuring failures to update the built module manifest do not block the publish/release pipeline, aligning behavior with the task’s existing “warn and continue” design.
Changes:
- Add a
Test-Pathguard to verify the built manifest exists before attempting to update it. - Wrap
Update-ModuleManifest -ErrorAction Stopintry/catchand warn on failure instead of aborting the release.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…warning Addresses the #32 review nit: the catch warning now names the built manifest (like the missing-path warning) so logs identify which file failed to update. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Summary
Backports a robustness guard surfaced during the consumer rollout (PlexAutomationToolkit#56 review). The
UpdateReleaseNotestask is documented as non-fatal (it warns and returns on a missing/empty/unparseable changelog), but the finalUpdate-ModuleManifest -ErrorAction Stopwas unguarded — so a failure there (e.g. a missing built manifest, or anyUpdate-ModuleManifesterror) would hard-failPublish, contradicting the design.Now:
Test-Paththe built manifest, and wrapUpdate-ModuleManifestin try/catch that warns and leaves the existingReleaseNotesin place. The task is genuinely non-fatal at every step, so a release is never blocked.Brings the template level with the consumer PRs (JsmOperations / ReScenePS / SrrDBAutomationToolkit), which already include this guard.
build.psake.ps1parses OK.🤖 Generated with Claude Code
Summary by CodeRabbit