style: scope named parameters to multi-arg calls in test scaffolding

[tablackburn]

Summary

Aligns the test scaffolding this repo inherited from the template (tests/Help.tests.ps1, tests/Meta.tests.ps1, tests/MetaFixers.psm1) with the scoped named-parameter rule, plus two behavioral fixes the cross-repo audit surfaced.

The named-parameter rule was narrowed in ai-agent-instruction-modules#25 and applied to the template's own scaffolding in PowerShellModuleTemplate#36:

Name parameters only on calls that pass two or more arguments; a single-argument call stays positional.

An earlier revision of this PR predated that scoping and added names to single-argument calls. This revision matches the canonical template (the source of truth) line-for-line on every shared call site.

File	Change
tests/Help.tests.ps1	Single-argument calls go positional to match the template: Test-Path $path, Get-Module $Env:BHProjectName (×2), Import-Module $moduleManifestPath, Import-PowerShellDataFile $sourceManifest, Get-Help $command.Name, global:FilterOutCommonParameters …. Multi-argument / trailing-switch calls keep their names (Split-Path -Path $x -Parent, Join-Path -Path … -ChildPath …, Get-ChildItem -Path $x -Recurse). Plus the multi-paramset mandatory-skip fix (below).
tests/Meta.tests.ps1	Import-Module (Join-Path …), Get-TextFilesList $projectRoot, Test-FileUnicode $textFile, Select-String "<tab>" go positional. Get-Content -Path $f -Raw keeps its names (two args).
tests/MetaFixers.psm1	[ValidateNotNull()] on $FileInfo in ConvertTo-UTF8/ConvertTo-SpaceIndentation; [ValidateNotNullOrEmpty()] on $Root in Get-TextFilesList/Get-UnicodeFilesList (matches template). Test-FileUnicode $_ stays positional inside Get-UnicodeFilesList.

Why

PowerShellModuleTemplate#36 is the source of truth and reverses the "name everything" shape an earlier rule (template #23) had introduced. Naming the only argument of a call adds noise without removing ambiguity, so the scoped rule names parameters only when 2+ arguments are passed (a trailing switch such as -Raw/-Recurse/-Parent counts; common parameters like -Verbose/-ErrorAction do not). This PR brings the inherited scaffolds in line with the template's post-#36 files.

Two adjacent fixes bundled in per the cross-repo audit (these match the template and are unchanged from the prior revision):

1. Multi-paramset mandatory-skip block — the 'Has correct [mandatory] value' It now skips parameters whose IsMandatory status varies across parameter sets (with a clear reason) and normalizes case before comparing. Behavior is unchanged for parameters with consistent IsMandatory.
2. $parameterNames → $commandParameterNames — stale reference in the last Context block was silently passing nothing; the fix activates a previously no-op Context.

Out of scope

tests/Manifest.tests.ps1 is the older Module Dependency variant (no Test-VersionConstraint helper, no $isTemplate skip, -Child typo on Join-Path, positional Join-Path where the template now wants it named) — deferred to a separate uplift PR.

Test plan

• ./build.ps1 passes (build + Pester) on the local branch
• CI passes on Linux / macOS / Windows runners
• PSScriptAnalyzer remains clean

🤖 Generated with Claude Code

Summary by CodeRabbit

• Tests

  • Improved test suite: stricter input validation for utilities, more robust help/parameter assertions (handles varying parameter requirements across contexts), and enhanced discovery/setup behavior to reduce false positives.

• Chores

  • Adjusted test setup and path handling for more reliable module loading and content checks; standardized invocation styles for test helpers.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 91b46ad0-59a9-4392-8c6c-89867645d4ab

📥 Commits

Reviewing files that changed from the base of the PR and between 025e417 and 26db59f.

📒 Files selected for processing (3)

• tests/Help.tests.ps1
• tests/Meta.tests.ps1
• tests/MetaFixers.psm1

---

📝 Walkthrough

Walkthrough

Adds parameter validation attributes to test helper functions; updates tests/Meta.tests.ps1 call sites; and refines tests/Help.tests.ps1 bootstrap (path/BHBuildOutput), module import, help discovery calls, and per-parameter mandatory/presence assertions.

Changes

Test Infrastructure Parameter Validation and Help-Test Refinements

Layer / File(s)	Summary
Test helper parameter validation tests/MetaFixers.psm1	Adds [ValidateNotNull()] to FileInfo parameters of ConvertTo-UTF8 and ConvertTo-SpaceIndentation, and [ValidateNotNullOrEmpty()] to Root parameters of Get-TextFilesList and Get-UnicodeFilesList.
Meta tests call-site updates tests/Meta.tests.ps1	Import-Module now receives the module path positionally; Get-Content is invoked with -Path $fileName -Raw in the tabs/indentation check.
Help tests bootstrap, import, discovery, and assertions tests/Help.tests.ps1	When BHBuildOutput is unset recompute project root with Split-Path -Path $PSScriptRoot -Parent, rebuild $Env:BHBuildOutput via Join-Path, call Import-Module $moduleManifestPath positionally, use positional args for Get-Help/FilterOutCommonParameters in BeforeDiscovery/BeforeAll, aggregate IsMandatory across parameter sets and skip mismatched cases, compare mandatory/required as lowercased strings, and assert help parameters against $commandParameterNames.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related issues

• style: enforce quoted literals, named parameters, and parameter validation SrrDBAutomationToolkit#16: Adds parameter validators and named -Path usage similar to this PR.
• style: enforce quoted literals, named parameters, and parameter validation PlexAutomationToolkit#50: Contains changes adding ValidateNotNull*/ValidateNotNullOrEmpty to helper cmdlets.
• style: enforce quoted literals, named parameters, and parameter validation ScheduledTasksManager#35: Related edits around parameter validation and test-call parameter conventions.

Possibly related PRs

• tablackburn/ReScenePS#11: Overlaps in tests/Help.tests.ps1 bootstrap logic and use of Split-Path -Parent for build environment setup.

Poem

🐰 I nudge the params to be non-null and neat,
Tests hop in line with paths that repeat.
Imports now tidy, help checks more wise,
A rabbit-approved patch — trimmed, clean, and precise. 🥕

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the primary change: applying style conventions to test scaffolding files by properly scoping named parameters to multi-argument calls, which is the core pattern throughout the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch style/align-test-scaffolding-with-template

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This pull request aligns the repository’s inherited test scaffolding and meta-fixer utilities with the canonical PowerShellModuleTemplate conventions (notably named-parameter usage) and includes two audit-driven correctness fixes in the help tests and meta fixers.

Changes:

• Standardize named-parameter usage across Help.tests.ps1 and Meta.tests.ps1 (e.g., Split-Path -Path ... -Parent, Get-Content -Path, Select-String -Pattern, Get-Module -Name).
• Reinstate/introduce a skip path in help tests for parameters whose mandatory status differs across parameter sets.
• Strengthen parameter validation in MetaFixers.psm1 and ensure Test-FileUnicode is invoked with -FileInfo.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
tests/Help.tests.ps1	Style cleanup + parameter-set-aware mandatory check; fixes a stale variable reference.
tests/Meta.tests.ps1	Style cleanup to use named parameters for consistency.
tests/MetaFixers.psm1	Add validation attributes and align helper calls with named parameters.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!