Fix multiselect list editor duplicate selections.#4862
Open
m3ftwz wants to merge 4 commits into
Open
Conversation
azmy60
reviewed
Apr 1, 2026
| } | ||
|
|
||
| if(this.params.multiselect) { | ||
| this.initialValues = null; |
Collaborator
There was a problem hiding this comment.
@m3ftwz is this really meant to be null? could you explain a little bit, please?
Author
There was a problem hiding this comment.
@azmy60 yes, initialValues is set to null after the first multiselect parse because it should only seed the initial selection once, while all later rebuilds must use currentItems as the real selected state source
Collaborator
|
Hey @m3ftwz , before this can be merged, would you be able to make a test for this? If it's possible, a simple test that would avoid regression is great. |
azmy60
added
the
PR Needs Work
Author
|
Haven’t had much time lately, but this is on my mind, I'll test it more as soon as I can :) |
Author
|
@azmy60 ready, thank you for your patience |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a weird behavior with multiselect in lists
Current
Screencast.From.2026-03-23.12-07-54.mp4
Fixed
Screencast.From.2026-03-23.12-06-49.mp4