fix: correct data tree child row aggregation in column calcs#4879
Open
lukecotter wants to merge 2 commits into
Open
fix: correct data tree child row aggregation in column calcs#4879lukecotter wants to merge 2 commits into
lukecotter wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes an issue where column calculations for data tree rows could include the parent row repeatedly instead of the child row data.
In the data tree calculation path, [rowsToData] iterates filtered child rows and should push each child row’s data into the calc input. The current logic pushes the parent [row] object instead, which causes incorrect summed values for expanded data tree branches.
fixes #4705