Skip to content

Support fetch-github-host-keys on windows runners #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eifinger merged 2 commits into from
Nov 24, 2025
Merged

Support fetch-github-host-keys on windows runners #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9027947
Test action on all runner types
eifinger Nov 24, 2025
645b668
Support fetch-github-host-keys on windows runners
eifinger Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
test:
strategy:
matrix:
runner: [ubuntu-slim, ubuntu-latest]
runner: [ubuntu-slim, ubuntu-latest, ubuntu-24.04-arm, macos-latest, windows-latest]
runs-on: ${{ matrix.runner }}
steps:
- uses: actions/checkout@v5
Expand All @@ -37,5 +37,5 @@ jobs:
- uses: ./
with:
ssh-private-key: ${{ secrets.CI_DEPLOY_KEY_PRIVATE_KEY }}
fetch-github-host-keys: ${{ matrix.runner == 'ubuntu-slim' }}
- run: git clone git@github.com:tadodotcom/ssh-agent.git /tmp/ssh-agent-clone
fetch-github-host-keys: ${{ matrix.runner == 'ubuntu-slim' || matrix.runner == 'windows-latest' }}
- run: git clone git@github.com:tadodotcom/ssh-agent.git ssh-agent-clone
11 changes: 7 additions & 4 deletions dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3697,10 +3697,13 @@ try {
if (fetchGithubHostKeys) {
console.log("Fetching GitHub host keys");
try {
const metaJson = child_process.execSync(
"curl --silent https://api.github.com/meta",
{ encoding: "utf8" },
);
// Use curl which is available on all GitHub Actions runners (Linux, macOS, Windows)
const curlCmd =
process.platform === "win32"
? "curl.exe --silent https://api.github.com/meta"
: "curl --silent https://api.github.com/meta";

const metaJson = child_process.execSync(curlCmd, { encoding: "utf8" });

const meta = JSON.parse(metaJson);
const knownHostsFile = `${homeSsh}/known_hosts`;
Expand Down
11 changes: 7 additions & 4 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,13 @@ try {
if (fetchGithubHostKeys) {
console.log("Fetching GitHub host keys");
try {
const metaJson = child_process.execSync(
"curl --silent https://api.github.com/meta",
{ encoding: "utf8" },
);
// Use curl which is available on all GitHub Actions runners (Linux, macOS, Windows)
const curlCmd =
process.platform === "win32"
? "curl.exe --silent https://api.github.com/meta"
: "curl --silent https://api.github.com/meta";

const metaJson = child_process.execSync(curlCmd, { encoding: "utf8" });

const meta = JSON.parse(metaJson);
const knownHostsFile = `${homeSsh}/known_hosts`;
Expand Down