Add support for setting the encoding and collation#54
Open
minusbat wants to merge 2 commits intotagomoris:masterfrom
Open
Add support for setting the encoding and collation#54minusbat wants to merge 2 commits intotagomoris:masterfrom
minusbat wants to merge 2 commits intotagomoris:masterfrom
Conversation
Simply add these to the config variables and pass them down to mysql2 along with all the rest.
…config Add support for setting the enconding and collation
Collaborator
|
@minusbat |
Author
|
Ah, apparently I imagined that! It does have encoding though, and the patch works. Possibly should remove the collation option if its not actually supported by the mysql2 client library. |
Collaborator
What is the case when it is support? |
Collaborator
|
ref: #53 |
|
What is preventing this from entering the package? It's 2024 and this little thing breaks scenarios as soon as an emoji flows into the context. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple changes to allow the encoding and collation attributes for mysql2 to be set on the fluent plugin.
This is necessary to enable the writing of utf8mb4 data into mysql out of fluent, as otherwise the connection defaults to utf8 and the conversion fails. You need this to support emoji for example, or any other characters outside of 3 byte UTF-8.