Skip to content

Conversation

@naanci
Copy link
Collaborator

@naanci naanci commented Jan 28, 2026

683

Description of changes

Added rounded corner (card) for leaderboard embed just like the ones POTD has

Checklist before review

  • I have done a thorough self-review of the PR
  • Copilot has reviewed my latest changes, and all comments have been fixed and/or closed.
  • If I have made database changes, I have made sure I followed all the db repo rules listed in the wiki here. (check if no db changes)
  • All tests have passed
  • I have successfully deployed this PR to staging
  • I have done manual QA in both dev (and staging if possible) and attached screenshots below.

Screenshots

Dev

Staging

Screenshot 2026-02-01 at 2 56 16 AM

@naanci
Copy link
Collaborator Author

naanci commented Jan 28, 2026

/deploy

@github-actions
Copy link
Contributor

Available PR Commands

  • /ai - Triggers all AI review commands at once
  • /review - AI review of the PR changes
  • /describe - AI-powered description of the PR
  • /improve - AI-powered suggestions
  • /deploy - Deploy to staging

See: https://github.com/tahminator/codebloom/wiki/CI-Commands

@naanci naanci changed the title Rounded corners for leaderboard embed 683: Rounded corners for leaderboard embed Jan 28, 2026
@github-actions
Copy link
Contributor

The command to deploy to staging for the commit cbce074 has been triggered. View action run

@github-actions
Copy link
Contributor

Title

683: Rounded corners for leaderboard embed


PR Type

Enhancement


Description

  • Wrap leaderboard embed in Card

  • Add border, padding, medium radius

  • Maintain full-width flexible column layout


Diagram Walkthrough

flowchart LR
  OrgEmbed["OrgEmbedView.tsx"]
  CardWrap["Wrap content in Card"]
  Styles["Border, padding, radius, flex column"]

  OrgEmbed -- "update JSX and imports" --> CardWrap
  CardWrap -- "apply visual styles" --> Styles
Loading

File Walkthrough

Relevant files
Enhancement
OrgEmbedView.tsx
Wrap embed content in styled Card                                               

js/src/app/embed/leaderboard/_components/OrgEmbedView.tsx

  • Import Card from UI library.
  • Wrap returned content with instead of fragment.
  • Apply withBorder, radius="md", p="md", w="100%", flex column styles.
  • Replace closing fragment with .
+12/-2   

@github-actions
Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Layout Regression

Wrapping the previous fragment in a Card changes layout and background/border; verify this matches the Notion acceptance criteria and other embeds (POTD) styling, including padding, border radius, and responsiveness across themes.

<Card
  withBorder
  radius="md"
  p="md"
  w="100%"
  display="flex"
  style={{
    flexDirection: "column",
  }}
>
Theming Consistency

Ensure the Card respects existing theme tokens (dark/light modes) and does not clash with surrounding container backgrounds in embed contexts; confirm contrast and border visibility.

<Card
  withBorder
  radius="md"
  p="md"
  w="100%"
  display="flex"
  style={{
    flexDirection: "column",
  }}
>

@github-actions
Copy link
Contributor

Staging deployment succeeded for commit cbce074

View run

@naanci
Copy link
Collaborator Author

naanci commented Jan 28, 2026

/deploy

@github-actions
Copy link
Contributor

Commit Validation Failed

The following commits do not start with the required Notion ID 683:

684: removed excess padding thats no longer needed

Please rebase and update your commit messages.
All messages should be of the following format: 683: Example commit

@github-actions
Copy link
Contributor

The command to deploy to staging for the commit ace0b9c has been triggered. View action run

@github-actions
Copy link
Contributor

Staging deployment succeeded for commit ace0b9c

View run

@naanci
Copy link
Collaborator Author

naanci commented Jan 28, 2026

/deploy

@github-actions
Copy link
Contributor

The command to deploy to staging for the commit 8bf399f has been triggered. View action run

@github-actions
Copy link
Contributor

Staging deployment succeeded for commit 8bf399f

View run

@tahminator
Copy link
Owner

/deploy

@github-actions
Copy link
Contributor

The command to deploy to staging for the commit b32d075 has been triggered. View action run

@tahminator
Copy link
Owner

/copy

1 similar comment
@tahminator
Copy link
Owner

/copy

@github-actions
Copy link
Contributor

Database copy command failed!

@tahminator
Copy link
Owner

/copy

@github-actions
Copy link
Contributor

Staging deployment succeeded for commit b32d075

View run

@github-actions
Copy link
Contributor

Database copy command failed!

@tahminator
Copy link
Owner

/copy

@github-actions
Copy link
Contributor

Database copy command completed successfully!

@naanci
Copy link
Collaborator Author

naanci commented Jan 31, 2026

/deploy

@github-actions
Copy link
Contributor

The command to deploy to staging for the commit 1422321 has been triggered. View action run

@github-actions
Copy link
Contributor

Staging deployment succeeded for commit 1422321

View run

@naanci
Copy link
Collaborator Author

naanci commented Feb 1, 2026

/deploy

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2026

Commit Validation Failed

The following commits do not start with the required Notion ID 683:

change to using flex

Please rebase and update your commit messages.
All messages should be of the following format: 683: Example commit

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2026

The command to deploy to staging for the commit b49b4fb has been triggered. View action run

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2026

Staging deployment succeeded for commit b49b4fb

View run

@codecov
Copy link

codecov bot commented Feb 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants