device: further add, revise API for on-demand configuration of peers#48
Open
device: further add, revise API for on-demand configuration of peers#48
Conversation
bradfitz
force-pushed
the
bradfitz/noconfig3
branch
from
a62a566 to
3ed34ca
Compare
Updates tailscale/tailscale#17858 Updates tailscale/corp#35603 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
bradfitz
force-pushed
the
bradfitz/noconfig3
branch
from
3ed34ca to
3ea3f56
Compare
raggi
reviewed
Feb 10, 2026
| } | ||
| } | ||
|
|
||
| func parseIPv6AddrPorts(p []byte) (src, dst netip.AddrPort, err error) { |
Member
There was a problem hiding this comment.
I'm slightly concerned with this being here, and for completeness needing more data, like session state (if we're going to completely get fragmentation/routing extensions right).
It would probably be better to pass the whole buffer down through the lookup extension. It'll still need a shallow address extraction for the non-extension case, but that won't need to parse any extension headers or ports on the wireguard-go side.
I also think it'll be easier to iterate on details that way, as we can use our experiments infrastructure back at home.
Member
|
Rest of the PR looks great, glad to have the optimzation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates tailscale/tailscale#17858
Updates tailscale/corp#35603