Updated dependencies and allow falafel-options pass through.#5
Open
kaltsimon wants to merge 1 commit intotakeshi:masterfrom
Open
Updated dependencies and allow falafel-options pass through.#5kaltsimon wants to merge 1 commit intotakeshi:masterfrom
kaltsimon wants to merge 1 commit intotakeshi:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates several key dependencies to newer versions and adds support for passing custom falafel parser options, enabling better configuration for modern JavaScript/TypeScript parsing (e.g., ES6 module support).
- Updated four npm dependencies (falafel, gulp, gulp-typescript, through2) to newer versions
- Added
falafelOptionsconfiguration interface and default values - Modified the transform function to use the new configurable falafel options
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updated dependencies: falafel (1.0.1→2.1.0), gulp (3.8.11→3.9.1), gulp-typescript (2.5.0→3.1.6), through2 (0.6.3→2.0.3) |
| index.ts | Added falafelOptions interface property with ecmaVersion and sourceType support, implemented default options initialization, and updated transform function to use new options |
| index.js | Compiled JavaScript output reflecting the TypeScript changes, including the new falafelOptions handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| falafelOptions?: { | ||
| ecmaVersion?: 3 | 5 | 6 | 7 | 8; | ||
| sourceType?: 'script' | 'module'; | ||
| tolerant: boolean; |
There was a problem hiding this comment.
The tolerant property should be optional (marked with ?) to match the pattern of other properties in the interface and allow users to override only specific options without being forced to provide all properties.
Suggested change
| tolerant: boolean; | |
| tolerant?: boolean; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The newer falafel version and the pass through of options to it, allow for better configuration. E.g.
{sourceType: "module"}allows one to configure TypeScript to output ES6 modules.