Skip to content

add winmain.h to fix build#15

Open
humem wants to merge 1 commit intotaku910:masterfrom
humem:patch
Open

add winmain.h to fix build#15
humem wants to merge 1 commit intotaku910:masterfrom
humem:patch

Conversation

@humem
Copy link
Copy Markdown

@humem humem commented Apr 23, 2015

winmain.h is taken from the latest crfpp version 0.59 archive stored in googlecode

@arne-cl
Copy link
Copy Markdown

arne-cl commented Jul 11, 2015

Without the patch, compilation doesn't work.

$ /opt/crfpp# make
make  all-am
make[1]: Entering directory `/opt/crfpp'
g++ -DHAVE_CONFIG_H -I.     -O3 -Wall -c -o crf_learn.o crf_learn.cpp
crf_learn.cpp:9:21: fatal error: winmain.h: No such file or directory
 #include "winmain.h"
                     ^
compilation terminated.
make[1]: *** [crf_learn.o] Error 1
make[1]: Leaving directory `/opt/crfpp'
make: *** [all] Error 2

@tavianator tavianator mentioned this pull request Oct 26, 2015
@ghost
Copy link
Copy Markdown

ghost commented Apr 14, 2016

Worked around this on OS X by adding a

#ifdef _WIN32
#include "winmain.h"
#endif

@icoxfog417
Copy link
Copy Markdown

Thank you for the fix. It works for me. I'm waiting this is merged to master.

@shboy
Copy link
Copy Markdown

shboy commented Jan 2, 2019

Worked around this on OS X by adding a

#ifdef _WIN32
#include "winmain.h"
#endif

good

ringsaturn referenced this pull request in ringsaturn/crfpp Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants