Fix crash in tagger when next() is called before parse()#52
Open
brandon-fry wants to merge 2 commits intotaku910:masterfrom
Open
Fix crash in tagger when next() is called before parse()#52brandon-fry wants to merge 2 commits intotaku910:masterfrom
brandon-fry wants to merge 2 commits intotaku910:masterfrom
Conversation
Adds a null pointer check to the agenda_ member in next before accessing it. Normally, agenda_ is allocated when parse is called, so the call to next will only seg fault if it is called before parse. For cases of empty input from a user, parse may not get called, but next should return false in this case without crashing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a null pointer check to the agenda_ member in next before accessing it.
Normally, agenda_ is allocated when parse is called, so the call to next
will only seg fault if it is called before parse. For cases of empty input
from a user, parse may not get called, but next should return false in this
case without crashing.