Add network aggregate metrics, per-interface errors, and PMID fixes#11
Merged
Conversation
Covers network.all.* aggregates, per-interface errors, and PMID corrections to match real Linux PMDA assignments.
Clarify PMID correction semantics, add error_rate validation range, document cluster 90 item gaps, and flesh out full test plan.
Address review findings: explicit CLI entry deletion step, fix broken test_instance_names iteration, task interdependency note, man page prose placement, correct metric count 63->71.
Support optional error injection for network metrics. Validated 0.0-1.0, same pattern as noise field.
Correct CLUSTER_NET_DEV item numbers to match Linux PMDA. Add 6 network.all.* aggregate + 2 per-interface error descriptors.
Totals-first pattern matching disk domain. Errors driven by optional error_rate stressor field, default 0.
Total metric count: 63 -> 71.
Mandoc requires lines under 80 chars. Also caught two hardcoded counts in test_cli.py missed by Task 4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
network.all.*aggregate metrics (bytes, packets, errors — in/out) that roll up per-interface valuesnetwork.interface.{in,out}.errorsper-interface error countersCLUSTER_NET_DEV=3) item numberingerror_ratestressor field for network error injection (defaults to 0)sum(per-interface) == aggregateguaranteed exactlysrc/pmdas/linux/pmda.c—CLUSTER_NET_ALL=90for aggregatesTest plan
./pre-commit.shgreen: ruff, mypy, mandoc, 461 unit/integration + 7 E2E tests🤖 Generated with Claude Code