Open
Conversation
… with allocator and clients
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds shared bearer token authentication to all machine-to-machine API endpoints on the allocator, preventing unauthorized access from the public internet. Implements the solution proposed in #280.
Changes
Added
require_api_tokendecorator inmain.pythat validatesAuthorization: Bearer <token>headers using constant-time comparison (secrets.compare_digest)secrets.token_urlsafe(32)API_TOKEN)subscribe.py,check_gpu.py,update_inuse_status.py)user_data.sh(status updates, metrics)api_tokenTerraform variable (markedsensitive) plumbed throughvariables.tf→main.tf→user_data.sh/api/request_vmexemptionChanged
headersparameter in HTTP callsProtected Endpoints
/vm_startup/api/unassigned_vms_count/api/update_inuse_status/api/gpu_health/api/vm-status/api/vm-status/<hostname>/api/vm-logs/api/vm-logs/<hostname>/api/vm-metrics/<hostname>/api/request_vmTechnical Details
terraform destroy), token persistence is unnecessary.terraform.runtime.tfvarsduring/api/launchand passed to VMs via cloud-init environment variable.require_api_tokendecorator usessecrets.compare_digestto prevent timing attacks.Testing
ruff check)Related Issues
Closes #280
Related to #83
🤖 Generated with Claude Code