Skip to content

chore(sdk): prepare package for npm publishing#36

Open
Abdulmuiz44 wants to merge 1 commit into
mainfrom
chore/sdk-publish-readiness
Open

chore(sdk): prepare package for npm publishing#36
Abdulmuiz44 wants to merge 1 commit into
mainfrom
chore/sdk-publish-readiness

Conversation

@Abdulmuiz44
Copy link
Copy Markdown
Collaborator

  • Prepares @cliploop/sdk package metadata, build output, exports, and npm files.
  • Adds publish-readiness scripts and dry-run packaging checks.
  • Does not publish the package.
  • Does not change backend/API behavior.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1b1b2f7730

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

"scripts": {
"build": "tsc -p tsconfig.json",
"typecheck": "tsc -p tsconfig.json --noEmit",
"prepack": "npm run build",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove the private flag before publishing

When this package is actually published via the new prepack packaging path, package.json still has "private": true on line 4; npm's package-json docs state that this makes npm refuse to publish the package. That leaves the SDK buildable for packaging checks but blocks a real npm publish, so the package should drop the private flag or otherwise be made intentionally publishable before this is considered npm-ready.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant