Skip to content

Add captures for fractional decimal numbers#2100

Open
Enyium wants to merge 7 commits intotalonhub:mainfrom
Enyium:pr-float-capture
Open

Add captures for fractional decimal numbers#2100
Enyium wants to merge 7 commits intotalonhub:mainfrom
Enyium:pr-float-capture

Conversation

@Enyium
Copy link
Copy Markdown
Contributor

@Enyium Enyium commented Jan 1, 2026 •
edited
Loading

Benefits:

  • I implemented basic mouse move commands that move the mouse cursor the said amount of centimeters (changeable to inches and other units), which I plan to contribute in the future. Centimeter values like "point five" or "two point five" are a regular occurrence.
  • Rango's commands "upper" and "downer" currently only accept integers to scroll whole pages. The only fractional amount is used when omitting the number (0.66 pages). It's very easy to update Rango to simply use a float capture instead to allow for any fractional amount like "point five" or "one point five", or even "point one" or "point oh one" (like when you just scrolled, but the mouse cursor needs to get out of the way ever so slightly).
  • EDIT: Input float literals into code editors, calculator apps, etc.

auscompgeek
auscompgeek requested changes Jan 2, 2026
View reviewed changes
Comment thread core/numbers/numbers.py Outdated
@Enyium Enyium changed the title Added captures number_float and number_float_signed Add number_... captures for floats Jan 2, 2026
auscompgeek
auscompgeek reviewed Jan 2, 2026
View reviewed changes
Comment thread core/numbers/numbers.py Outdated
Enyium added 5 commits January 3, 2026 15:38
@Enyium
Added test for digit_string capture.
1ea6b17
@Enyium
Abstracted implementation of negation captures.
9f8692e
@Enyium
Added captures for fractional decimal numbers.
27437c5
@Enyium
Improved doc comments of earlier number captures.
a0c108d 
This follows the example of the new decimal captures and makes for more consistency.

- Removed "Parses...phrase". Every capture converts from a spoken form.
- Removed information that's already in the capture name like, "returning that number as a string."
- Made some doc comments refer to other captures' doc comments to avoid duplication and because this makes correct maintenence more likely. An excessive need to check whether a change invalidated a tiny part of another capture's doc comment can drive you crazy.
- Added missing doc comments of captures that weren't too complex to understand or describe.
@Enyium
Used new decimal captures for existing code.
ca0db08 
Extended the value range to include negative numbers, because it seemed appropriate.
@Enyium
Copy link
Copy Markdown
Contributor Author

Enyium commented Jan 3, 2026

I overhauled everything.

@Enyium Enyium changed the title Add number_... captures for floats Add captures for fractional decimal numbers Jan 3, 2026
@Enyium
Changed (un)prefixed number input to allow for fractions.
7a0db77 
This is done indirectly through `user.number_prose_unprefixed`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@auscompgeek auscompgeek auscompgeek requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Enyium @auscompgeek