Skip to content

Add support for the dolphin file manager#2182

Merged
nriley merged 2 commits into
talonhub:mainfrom
BlueDrink9:dolphin
May 9, 2026
Merged

Add support for the dolphin file manager#2182
nriley merged 2 commits into
talonhub:mainfrom
BlueDrink9:dolphin

Conversation

@BlueDrink9
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 945410121e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread apps/dolphin/dolphin.py Outdated
@FireChickenProductivity
Copy link
Copy Markdown
Contributor

Just a note: (refresh | reload) it: browser.reload() is already a command in Community. I wonder if it might be worth copying that spoken form if you are using reload it and if we should at some point abstract out reloading from just being a browser thing.

@FireChickenProductivity
Copy link
Copy Markdown
Contributor

Another note: file rename is defined in several contexts. We might want to put that behind a tag so we can use action overriding.
(These notes are mostly intended for the next backlog session)

Comment thread apps/dolphin/dolphin.py Outdated
Comment thread apps/dolphin/dolphin.talon
@BlueDrink9
Copy link
Copy Markdown
Contributor Author

I was surprised to find that file rename was not already in the file manager tag.

I find myself creating a reload or refresh command for quite a lot of applications, comma it definitely seems generally useful outside of just browsers. That being said, it does feel like a nuisance to have a tag for just a single command, but I suppose that's better than making users redefine the command for every application.

Comment thread apps/dolphin/dolphin.py Outdated
Copy link
Copy Markdown
Collaborator

@nriley nriley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the Community Backlog session — please address all of @FireChickenProductivity 's issues. Thanks!

Comment thread apps/dolphin/dolphin.py Outdated
@BlueDrink9 BlueDrink9 force-pushed the dolphin branch 4 times, most recently from 78e9475 to 304fe7f Compare May 5, 2026 05:52
@BlueDrink9 BlueDrink9 closed this May 5, 2026
@BlueDrink9 BlueDrink9 deleted the dolphin branch May 5, 2026 21:31
@BlueDrink9 BlueDrink9 restored the dolphin branch May 6, 2026 23:28
@BlueDrink9 BlueDrink9 reopened this May 6, 2026
@nriley nriley merged commit 0b78c6f into talonhub:main May 9, 2026
3 checks passed
@StructSeeker
Copy link
Copy Markdown

You seems to omit a from typing import Optional that cause error message in windows?
@BlueDrink9

@nriley
Copy link
Copy Markdown
Collaborator

nriley commented May 10, 2026

Yup, sorry we did not test it! The needed changes are in another PR currently; see fab4300. @BlueDrink9 if you want to submit as a separate PR then happy to merge ASAP.

@FireChickenProductivity
Copy link
Copy Markdown
Contributor

Adding the optional import actually causes another error because it makes the type signature inconsistent with the base action.

@FireChickenProductivity
Copy link
Copy Markdown
Contributor

I submitted the quickest fix: #2193

@BlueDrink9
Copy link
Copy Markdown
Contributor Author

Oops, thank you! I'm on beta so for whatever reason didn't get the error; or maybe just didn't notice it in the log. Thanks FireChicken, and sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants