Add support for the dolphin file manager#2182
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 945410121e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Just a note: |
|
Another note: |
|
I was surprised to find that file rename was not already in the file manager tag. I find myself creating a reload or refresh command for quite a lot of applications, comma it definitely seems generally useful outside of just browsers. That being said, it does feel like a nuisance to have a tag for just a single command, but I suppose that's better than making users redefine the command for every application. |
nriley
left a comment
There was a problem hiding this comment.
From the Community Backlog session — please address all of @FireChickenProductivity 's issues. Thanks!
78e9475 to
304fe7f
Compare
for more information, see https://pre-commit.ci
|
You seems to omit a |
|
Yup, sorry we did not test it! The needed changes are in another PR currently; see fab4300. @BlueDrink9 if you want to submit as a separate PR then happy to merge ASAP. |
|
Adding the optional import actually causes another error because it makes the type signature inconsistent with the base action. |
|
I submitted the quickest fix: #2193 |
|
Oops, thank you! I'm on beta so for whatever reason didn't get the error; or maybe just didn't notice it in the log. Thanks FireChicken, and sorry! |
No description provided.