Skip to content

feat: icons, project.scripts#195

Merged
cwo3990 merged 6 commits intomainfrom
feat/icons-project-scripts
Feb 18, 2026
Merged

feat: icons, project.scripts#195
cwo3990 merged 6 commits intomainfrom
feat/icons-project-scripts

Conversation

@hiromon0125
Copy link
Copy Markdown
Contributor

Description

  • icons set for all operating systems
  • project.scripts to properly package commander and run commander

Metrics

  • PR Confidence value(1 ~ 5): 4

Copy link
Copy Markdown
Contributor

@cwo3990 cwo3990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issues:

  1. uv run commander-tk gave this error:
Traceback (most recent call last):
File "/Users/connor/talos-rit/commander/.venv/bin/commander-tk", line 10, in <module>
  sys.exit(tk_interface())
           ^^^^^^^^^^^^^^
TypeError: tk_interface() missing 1 required positional argument: 'args'
  1. uv run commander-terminal gave this error:
Traceback (most recent call last):
File "/Users/connor/talos-rit/commander/.venv/bin/commander-terminal", line 10, in <module>
  sys.exit(terminal_interface())
           ^^^^^^^^^^^^^^^^^^^^
TypeError: terminal_interface() missing 1 required positional argument: 'args'
  1. On my machine (macOS 26 with Intel-based processor), when running uv run commander, the icon doesn't show up at the top left of the tkinter interface window between the close, minimize, and expand buttons and the window title. It shows up as a placeholder. This is probably just some weird tkinter issue on macOS, but it doesn't seem to affect the app itself. It could be worth looking into, but I'm fine ignoring it since the icons are just cosmetic. The good news is that it shows up in the dock. See the attached screenshot below.
Image

@hiromon0125 hiromon0125 requested a review from cwo3990 February 17, 2026 17:25
Copy link
Copy Markdown
Contributor

@cwo3990 cwo3990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Too bad about the title bar icons

@cwo3990 cwo3990 merged commit 9af613c into main Feb 18, 2026
@cwo3990 cwo3990 deleted the feat/icons-project-scripts branch February 18, 2026 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants