Practice 015 - Carlos#61
Open
cadaar wants to merge 2 commits into
Open
Conversation
Carop13
reviewed
Jan 5, 2018
| <footer> | ||
| <div class="dropdown"> | ||
| <label for="about">Lorem ipsum dolor sit amet</label> | ||
| <input type="checkbox" id="about"> |
Contributor
There was a problem hiding this comment.
I don't think any of this checkbox is need it
| display: none; | ||
| } | ||
|
|
||
| footer input[type='checkbox'] { |
Contributor
There was a problem hiding this comment.
I don't think this is need it
| padding: 40px 50px; | ||
| } | ||
|
|
||
| footer .content { |
Author
There was a problem hiding this comment.
It is, when the resolution is <= 768px the footer hides the content and only shows the headings
Carop13
reviewed
Jan 5, 2018
| <div class="page-content"> | ||
| <!-- Practice Content Goes Here --> | ||
| <section class="main-content"> | ||
| <div class="card-wrapper"> |
Contributor
There was a problem hiding this comment.
this should be and < article >
| </div> | ||
| </section> | ||
| <footer> | ||
| <div class="dropdown"> |
Contributor
There was a problem hiding this comment.
These div's should a < section >
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.