ReconnectingWebsocket: Exit on connection error.#1
Open
tamaralipows wants to merge 14 commits into
Open
Conversation
Owner
tamaralipows
commented
Nov 15, 2023
tamaralipows
commented
- First we start with debug logs.
This try: except: lock can be problematic, since all exceptions will be caught here, including asyncio.CancelledError from the parent task, which we do not want to catch.
Not raising here and simply catching the error means the parent task will fail to be properly cancelled if the parent receives a cancellation error.
- This allows to check for cancellations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.