Replace go-rod with chromedp for installability - #73
Draft
SihanTeng wants to merge 2 commits into
Draft
Conversation
The chromedp migration rooted tab contexts at the pool allocator, so Ctrl-C no longer aborted an in-flight render (it blocked until the render timeout), and chromedp's Evaluate does not await promises, so --scroll snapshotted before the scroll and its lazy loads finished. Forward the caller's context into the tab with context.AfterFunc and pass WithAwaitPromise to the scroll evaluation. Also log partial serialise failures instead of swallowing them, drop a dead error branch, correct the settle doc comment, and note the migration's two intentional behavior changes (no stealth evasions, fixed settle wait) in the changelog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
replaceforgithub.com/ysmood/leaklessand remove the third-party stub.go install github.com/tamnd/kage/cmd/kage@latestwhile keeping Windows AV clean (no embedded leakless helper).Why
go install …@versionrejects modules that containreplacedirectives (#72). The leakless replace fixed Defender false positives (#68) but broke the documented install path. Moving off go-rod’s launcher removes leakless from the graph entirely.Test plan
go test -short -count=1 ./...go test -count=1 ./browser/ ./clone/with Chrome presentgo list -deps ./cmd/kagehas noleakless/go-rodgo install github.com/tamnd/kage/cmd/kage@latestCloses #72
Related: #68