api: fix Graphite configuration validation - #49
Merged
themilchenko merged 3 commits intoAug 7, 2026
Conversation
The removal of the `graphite` section is handled by the same loop as the http one, but goes through another code path. Check that the exporters are stopped after such a reload.
`validate_graphite()` checked the metrics version by calling `graphite.stop()`, which kills all running exporters. As `apply_graphite()` skips initialization when the configuration is not changed, any `config:reload()` that kept the graphite section as is silently stopped the export. Now the check does not touch the plugin.
The support check was performed for any configuration mentioning the `graphite` section, including an empty one. Such a section does not start any exporter, so there is nothing to check. Now the check runs only if at least one graphite node is configured.
DifferentialOrange
approved these changes
Aug 7, 2026
DerekBum
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch set contains bug fixes related to config reload and a test for graphite target removal.