Add prepared statements performance optimization to increase observation performance x2#535
Open
maksimuimin wants to merge 5 commits intotarantool:masterfrom
Open
Add prepared statements performance optimization to increase observation performance x2#535maksimuimin wants to merge 5 commits intotarantool:masterfrom
maksimuimin wants to merge 5 commits intotarantool:masterfrom
Conversation
added 5 commits
November 26, 2025 12:49
Make it impossible to override lable_keys in make_key
…age and GC preassure
Author
|
d8dd7c7 <- this commit needs attention, the test is red on master, couldn't make it work on my Mac, just skipped it |
Contributor
|
Thank you for the patch! How do you calculate the performance improvment? Do you have any script/repro for it? |
bigbes
reviewed
Jan 21, 2026
| self.label_pairs[key] = label_pairs | ||
| for i = 1, self.age_buckets_count do | ||
| local quantile_obj = Quantile.NewTargeted(self.objectives) | ||
| self.collector.label_pairs[key] = self.label_pairs |
There was a problem hiding this comment.
Should self.collector.label_pairs be cleanupd in Summary.Prepared:remove()?
patapenka-alexey
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add prepared statements performance optimization to increase observation performance x2
I didn't forget about
Close #534