Skip to content

fix: prevent layout shift between active/inactive sidebar items - #128

Merged
tasercake merged 1 commit into
mainfrom
worktree/fix-sidebar-height-shift
Jul 14, 2026
Merged

fix: prevent layout shift between active/inactive sidebar items#128
tasercake merged 1 commit into
mainfrom
worktree/fix-sidebar-height-shift

Conversation

@tasercake

Copy link
Copy Markdown
Owner

Summary

  • keep root page active link padding consistent with inactive sidebar links
  • keep transient current-page sidebar entry padding consistent with normal page entries
  • leave active state to visual classes only

Verification

  • read lib/unfinal_web/components/layouts.ex and lib/unfinal_web/live/editor_live.ex
  • confirmed diff is limited to sidebar item padding in lib/unfinal_web/live/editor_live.ex

Note: mix deps.get/mix format --check-formatted could not complete on this VM because the Erlang runtime aborted with Monotonic time stepped backwards! during dependency fetch.

Active sidebar page entries used larger vertical padding for selected/current items, causing their computed height to differ from inactive entries. Keep padding consistent and only toggle visual active-state classes.
@tasercake
tasercake merged commit 4fdc994 into main Jul 14, 2026
1 check passed
@tasercake
tasercake deleted the worktree/fix-sidebar-height-shift branch July 14, 2026 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant