Conversation
- Bump pre-commit hooks: ruff-pre-commit v0.2.1 -> v0.15.12, pre-commit-hooks v4.4.0 -> v6.0.0 (both 2+ years stale) - Update ruff hook id from `ruff` (legacy alias) to `ruff-check` per the newer ruff-pre-commit naming - Apply lint findings the bumped ruff surfaces: PT001 (drop () from @pytest.fixture decorators), UP031 (percent-format -> f-string in utils.py), PT030 (add `match` to pytest.warns(DeprecationWarning)) - Drop black and isort from the dev dependency group; ruff and ruff-format already cover both Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
f1791e0 to
bad3a07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ruff-pre-commitv0.2.1 → v0.15.12 andpre-commit-hooksv4.4.0 → v6.0.0 (both 2+ years stale)ruff(legacy alias) toruff-checkper the newer ruff-pre-commit namingPT001: drop()from@pytest.fixturedecorators (8 occurrences acrosstests/)UP031: percent-format → f-string intaskbadger/utils.py:8PT030: addmatch=...to apytest.warns(DeprecationWarning)intest_project_key.pyUP007:Optional[X]→X | Nonein hand-written code (cli_main.py,cli/utils.py,mug.py)UP038:isinstance(x, (A, B))→isinstance(x, A | B)incelery.pyUP035: drop now-unusedtyping.Unionimport inmug.pyUP*andF*rules intaskbadger/internal/(generated by openapi-python-client; ~200 findings there are out of our hands)blackandisortfrom the dev dependency group —ruffandruff-format(already in pre-commit) cover bothThe
Optional[X]andisinstancefindings only appeared after #44 merged (which bumped rufftarget-versiontopy310); they're rolled into this PR since the rebase needed them anyway.Test plan
🤖 Generated with Claude Code