Skip to content

Add missing react- prefix #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tatethurston merged 1 commit into from
Mar 19, 2025
Merged

Add missing react- prefix #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/eslint-plugin-react-prefer-function-component/src/config.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ const config = {
"react-prefer-function-component": plugin,
},
rules: {
"react-prefer-function-component/prefer-function-component": "error",
"react-prefer-function-component/react-prefer-function-component":
"error",
Copy link
Copy Markdown
Contributor Author

@MariaSolOs MariaSolOs Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to split this into 2 lines to make Prettier happy.

Copy link
Copy Markdown
Owner

@tatethurston tatethurston Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I'm not seeing this when I run pnpm prettier --write packages/eslint-plugin-react-prefer-function-component/src/config.mts. The repo's lint check should pick up any issues too

Copy link
Copy Markdown
Contributor Author

@MariaSolOs MariaSolOs Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't include it initially but that caused the CI Prettier check to fail.

Copy link
Copy Markdown
Contributor Author

@MariaSolOs MariaSolOs Mar 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeap still fails if I undo it: https://github.com/tatethurston/eslint-plugin-react-prefer-function-component/actions/runs/13938189862/job/39010046479?pr=23#step:3:22

Copy link
Copy Markdown
Owner

@tatethurston tatethurston Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for confirming!

Copy link
Copy Markdown
Contributor Author

@MariaSolOs MariaSolOs Mar 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tatethurston because the name uses in the plugin’s rules property doesn’t match what the config references here. Just try linting using the “flat config” example from this repo and you’ll see the error.

Copy link
Copy Markdown
Owner

@tatethurston tatethurston Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thank you — I totally missed the prefix change and thought this was only a white space change.

I’m going to add a test case for this and I’ll cut a new release this evening.

Copy link
Copy Markdown
Contributor Author

@MariaSolOs MariaSolOs Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! Sorry for missing this in my previous PR.

Copy link
Copy Markdown
Owner

@tatethurston tatethurston Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not at all -- that was a testing gap. I've added a CI check for this. There is probably a more ergonomic solution, but it seems good enough for now:

#25

Copy link
Copy Markdown
Owner

@tatethurston tatethurston Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Published v4.0.1 with your fix

},
},
},
Expand Down