Make wikilinks and tags clickable in focus view

[tavva]

Summary

• Render focus action text with MarkdownRenderer.renderMarkdown() instead of plain setText(), making [[wikilinks]] and #tags clickable
• Add explicit click handlers for internal links (opens linked note) and tags (opens Obsidian tag search), since MarkdownRenderer doesn't set these up in custom ItemView contexts
• Extract shared handleRenderedTextClick method across all three item render paths (unpinned, pinned, completed)

Addresses item 3 of 4 from @DanValnicek's feedback in #37.

Test plan

• Wikilinks in focus items open the referenced note when clicked
• Tags in focus items open Obsidian's search with the tag query
• Clicking non-link text still navigates to the action's source file
• All 890 tests pass, build clean

Summary by CodeRabbit

Release Notes

• New Features

  • Added person note creation with template support and customizable folder paths
  • Introduced visual indicators for waiting-for actions and event tracking for action state changes
  • Enhanced focus highlighting with dynamic UI updates that reduce unnecessary page refreshes
  • Refactored system to support GTD features including sphere hierarchies, focus lists, and waiting-for tracking

• Settings

  • Added People Folder and Person Template File configuration options with support for variable substitution

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• ✅ Review completed - (🔄 Check again to review again)

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feature/clickable-focus-links

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 3

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/sphere-view.ts (1)

748-789: ⚠️ Potential issue | 🟡 Minor

Prevent link clicks from toggling focus in action items.

Now that action text is rendered as markdown, clicks on internal links/tags will bubble to the list item handler and toggle focus. Guard the handler to ignore anchor clicks so links stay clickable without changing focus state.

Suggested fix

     item.addEventListener("click", async (e) => {
+      const target = e.target;
+      if (target instanceof HTMLElement && target.closest("a")) {
+        return;
+      }
       // Capture element reference before any async operations
       const clickedElement = e.currentTarget as HTMLElement;

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/sphere-view.ts` around lines 748 - 789, The click handler attached to
item should ignore clicks that originate from anchors so internal markdown
links/tags remain clickable; inside the item.addEventListener("click", ...)
callback, check the event target (e.g., const target = e.target as HTMLElement)
and if target.closest("a") (or target instanceof HTMLAnchorElement) return
early, leaving link behavior untouched, then continue using the existing
finalLineResult, isOnFocus, removeFromFocus and addToFocus logic as before.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@docs/plans/2026-02-16-create-person-command-design.md`:
- Around line 1-47: The person template and modal logic must produce
Flow-compliant markdown: update the default template referenced by
personTemplateFilePath and the NewPersonModal creation flow to include YAML
frontmatter with creation-date, priority, tags (include project/person or
project/* as appropriate), status, and optional parent-project, plus the
required Title, Description, and Next actions sections; ensure NewPersonModal
replaces {{name}}, {{date}}, {{time}} and also inserts a Title line ("#
{{name}}"), a Description paragraph placeholder, and a "## Next actions"
section, and add a preflight check in the create-person command flow to
validate/normalize frontmatter fields and error if the target file already
exists.

In `@docs/plans/2026-02-16-create-person-command.md`:
- Around line 11-15: The document jumps from a top-level heading to `###` which
violates MD001; update the heading hierarchy by adding a `##` section heading
above the Task headings or promote each `### Task 1: Add settings fields` (and
subsequent Task headings) to `##` so headings increment by one; locate and edit
the heading lines in docs/plans/2026-02-16-create-person-command.md (e.g., the
"Task 1: Add settings fields" heading) and change the markdown level
accordingly.

In `@src/focus-view.ts`:
- Around line 910-943: The click handler handleRenderedTextClick assumes
e.target is an HTMLElement and calls closest(), which throws for Text nodes; add
a type guard at the top (e.g., const target = e.target; if (!(target instanceof
HTMLElement)) { this.openFile(item.file, item.lineNumber); return; }) so only
HTMLElements use closest() for internal-link, tag, and other link checks, and
non-HTMLElement targets immediately fall back to the default navigation via
openFile; ensure you still preventDefault() only when handling specific link
cases.

---

Outside diff comments:
In `@src/sphere-view.ts`:
- Around line 748-789: The click handler attached to item should ignore clicks
that originate from anchors so internal markdown links/tags remain clickable;
inside the item.addEventListener("click", ...) callback, check the event target
(e.g., const target = e.target as HTMLElement) and if target.closest("a") (or
target instanceof HTMLAnchorElement) return early, leaving link behavior
untouched, then continue using the existing finalLineResult, isOnFocus,
removeFromFocus and addToFocus logic as before.

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

Add required project frontmatter and sections for markdown compliance.

This doc is missing the required YAML frontmatter and the Title/Description/Next actions sections expected for Flow project markdown files.

✅ Suggested structure

+---
+creation-date: 2026-02-16T00:00:00
+priority: 3
+tags:
+  - project/flow
+status: planning
+---
+
+# Create Person Command
+
+## Description
+Add a "Create person" command to the Flow plugin so users can scaffold person notes via the command palette.
+
+## Next actions
+- [ ] Draft implementation plan and validate with existing create-project flow

As per coding guidelines "Flow projects must follow the project structure with YAML frontmatter including creation-date, priority, tags (project/*), status, and optional parent-project, followed by title, description, and next actions sections".

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@docs/plans/2026-02-16-create-person-command-design.md` around lines 1 - 47,
The person template and modal logic must produce Flow-compliant markdown: update
the default template referenced by personTemplateFilePath and the NewPersonModal
creation flow to include YAML frontmatter with creation-date, priority, tags
(include project/person or project/* as appropriate), status, and optional
parent-project, plus the required Title, Description, and Next actions sections;
ensure NewPersonModal replaces {{name}}, {{date}}, {{time}} and also inserts a
Title line ("# {{name}}"), a Description paragraph placeholder, and a "## Next
actions" section, and add a preflight check in the create-person command flow to
validate/normalize frontmatter fields and error if the target file already
exists.

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

Fix heading level jump (MD001).

The document jumps from # to ###. Add a ## section heading before the Task headings (or promote Tasks to ##) to keep increments by one.

Suggested fix

 ---
 
+## Tasks
+
 ### Task 1: Add settings fields

🧰 Tools

🪛 markdownlint-cli2 (0.21.0)

[warning] 13-13: Heading levels should only increment by one level at a time
Expected: h2; Actual: h3

(MD001, heading-increment)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@docs/plans/2026-02-16-create-person-command.md` around lines 11 - 15, The
document jumps from a top-level heading to `###` which violates MD001; update
the heading hierarchy by adding a `##` section heading above the Task headings
or promote each `### Task 1: Add settings fields` (and subsequent Task headings)
to `##` so headings increment by one; locate and edit the heading lines in
docs/plans/2026-02-16-create-person-command.md (e.g., the "Task 1: Add settings
fields" heading) and change the markdown level accordingly.

[coderabbitai]

⚠️ Potential issue | 🟠 Major

Guard against non-HTMLElement targets in click handling.

e.target can be a Text node, which doesn’t have closest(). That will throw and break clicks on plain text. Add a type guard before using closest, and fall back to the default navigation path.

Suggested fix

   private handleRenderedTextClick(e: MouseEvent, item: FocusItem): void {
-    const target = e.target as HTMLElement;
+    const target = e.target;
+    if (!(target instanceof HTMLElement)) {
+      void this.openFile(item.file, item.lineNumber);
+      return;
+    }

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	private handleRenderedTextClick(e: MouseEvent, item: FocusItem): void {
	const target = e.target as HTMLElement;
	// Handle clicks on internal links (wikilinks)
	const internalLink = target.closest("a.internal-link") as HTMLElement | null;
	if (internalLink) {
	e.preventDefault();
	const href = internalLink.getAttribute("data-href");
	if (href) {
	this.app.workspace.openLinkText(href, item.file);
	}
	return;
	}
	// Handle clicks on tags
	const tagLink = target.closest("a.tag") as HTMLElement | null;
	if (tagLink) {
	e.preventDefault();
	const tag = tagLink.textContent;
	if (tag) {
	const searchPlugin = (this.app as any).internalPlugins?.getPluginById?.("global-search");
	searchPlugin?.instance?.openGlobalSearch?.(`tag:${tag}`);
	}
	return;
	}
	// Handle clicks on any other link (e.g. external URLs)
	if (target.closest("a")) {
	return;
	}
	// Default: navigate to source file
	this.openFile(item.file, item.lineNumber);
	}
	private handleRenderedTextClick(e: MouseEvent, item: FocusItem): void {
	const target = e.target;
	if (!(target instanceof HTMLElement)) {
	void this.openFile(item.file, item.lineNumber);
	return;
	}
	// Handle clicks on internal links (wikilinks)
	const internalLink = target.closest("a.internal-link") as HTMLElement | null;
	if (internalLink) {
	e.preventDefault();
	const href = internalLink.getAttribute("data-href");
	if (href) {
	this.app.workspace.openLinkText(href, item.file);
	}
	return;
	}
	// Handle clicks on tags
	const tagLink = target.closest("a.tag") as HTMLElement | null;
	if (tagLink) {
	e.preventDefault();
	const tag = tagLink.textContent;
	if (tag) {
	const searchPlugin = (this.app as any).internalPlugins?.getPluginById?.("global-search");
	searchPlugin?.instance?.openGlobalSearch?.(`tag:${tag}`);
	}
	return;
	}
	// Handle clicks on any other link (e.g. external URLs)
	if (target.closest("a")) {
	return;
	}
	// Default: navigate to source file
	this.openFile(item.file, item.lineNumber);
	}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/focus-view.ts` around lines 910 - 943, The click handler
handleRenderedTextClick assumes e.target is an HTMLElement and calls closest(),
which throws for Text nodes; add a type guard at the top (e.g., const target =
e.target; if (!(target instanceof HTMLElement)) { this.openFile(item.file,
item.lineNumber); return; }) so only HTMLElements use closest() for
internal-link, tag, and other link checks, and non-HTMLElement targets
immediately fall back to the default navigation via openFile; ensure you still
preventDefault() only when handling specific link cases.