Changed building pos to BIS_fnc_buildingpositions#4
Closed
AnAngrySalad1 wants to merge 1 commit intotbeswick96:masterfrom
Closed
Changed building pos to BIS_fnc_buildingpositions#4AnAngrySalad1 wants to merge 1 commit intotbeswick96:masterfrom
AnAngrySalad1 wants to merge 1 commit intotbeswick96:masterfrom
Conversation
Changed building pos to BIS_fnc_buildingpositions as building pos doesn't work with none A3 buildings.
tbeswick96
requested changes
May 10, 2019
Owner
tbeswick96
left a comment
tbeswick96
left a comment
There was a problem hiding this comment.
Is there any proof of this.
Looking inside the function, it just calls buildingPos
The call arguments are also invalid. _house should be in square brackets
Author
So when I tested this in game, buildingPos didn't returned empty on A2 buildings, but the BIS_fnc did work |
Owner
|
Same as #3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed building pos to BIS_fnc_buildingpositions as building pos doesn't work with none A3 buildings.