This repository was archived by the owner on Jun 3, 2020. It is now read-only.
Add a basic Maven plugin to run the Transformer#102
Draft
jgallimore wants to merge 5 commits into
Draft
Conversation
Signed-off-by: Jonathan Gallimore <jgallimore@tomitribe.com>
Added standard Eclipse / Apache copyright header.
tbitonti
approved these changes
Apr 27, 2020
Owner
tbitonti
left a comment
There was a problem hiding this comment.
Added the standard copyright header to TransformMojo.java. Don't know if the build files need copyrights, so I left them alone.
Contributor
Author
|
Is there anything that I need to do to get this merged? Not a problem at all if its just a matter of time. If I need to do anything, I'm happy to help. |
Signed-off-by: Jonathan Gallimore <jgallimore@tomitribe.com>
Contributor
Author
|
Hold off doing anything with this - there are currently some issues I'm trying to resolve, specifically with the reference to biz.aQute.bnd:biz.aQute.bnd.transform:5.1.0-SNAPSHOT artifact in the jfrog repository, and changes to where the rules files are. |
…n is usuable. Fix issues where target filename not passed into the Transformer, and property file changes. Signed-off-by: Jonathan Gallimore <jgallimore@tomitribe.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will likely need some rework and tweaking, but thought I'd open this, and push further commits to it as necessary. This PR provides a basic Maven plugin. To use it, you'll need to at least push it to your local Maven repository on your machine, which you can achieve by running
To test is with a simple Maven project that builds a .war file, on your Maven project, you can run something like this:
mvn clean install org.eclipse.transformer:transformer-maven-plugin:0.1.0-SNAPSHOT:runand you should see the Transformer run after the .war file is created:
I would very much appreciate any feedback on this. Many thanks!