(ignore) Normative: Add private methods and getter/setters.#1667
Merged
ljharb merged 1 commit intotc39:masterfrom May 12, 2021
Merged
(ignore) Normative: Add private methods and getter/setters.#1667ljharb merged 1 commit intotc39:masterfrom
ljharb merged 1 commit intotc39:masterfrom
Conversation
Contributor
Author
|
This is on top of #1655; see Ms2ger/ecma262@class-fields...private-methods for just these changes. |
Ms2ger
force-pushed
the
private-methods
branch
from
7f5f487 to
48826f7
Compare
Member
|
Can you change the base branch of this PR to the one it's on top of? That way the diff will be readable. |
ljharb
added
needs test262 tests
Contributor
Author
|
I don't think so; that branch is in my own repo, not this one. |
Ms2ger
force-pushed
the
private-methods
branch
from
48826f7 to
9889a39
Compare
littledan
added
has test262 tests
and removed
needs test262 tests
ljharb
changed the title
Member
|
Deferring to #1668; I’ll keep this one up to date. |
…, private methods & getters/setters This includes changes from https://tc39.es/proposal-class-fields/. This includes changes from https://tc39.es/proposal-private-methods/. This includes changes from https://tc39.es/proposal-static-class-features/. Co-authored-by: Ms2ger <Ms2ger@gmail.com> Co-authored-by: Ujjwal Sharma <ryzokuken@igalia.com> Co-authored-by: Caio Lima <ticaiolima@gmail.com> Co-authored-by: Michael Dyck <jmdyck@ibiblio.org> Co-authored-by: Kevin Gibbons <bakkot@gmail.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes changes from https://tc39.es/proposal-private-methods/.