Editorial: avoid duplicate SetFunctionName in {async,}generator methods#2463
Merged
Editorial: avoid duplicate SetFunctionName in {async,}generator methods#2463
Conversation
syg
approved these changes
Aug 4, 2021
michaelficarra
approved these changes
Aug 4, 2021
bakkot
added
the
ready to merge
ljharb
force-pushed
the
generator-method-setfunctionname
branch
from
7daa47b to
fcabfe0
Compare
mathiasbynens
pushed a commit
to mathiasbynens/ecma262
that referenced
this pull request
Oct 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1668 introduced a
DefineMethodPropertymethod for use when creating plain methods, generator methods, async methods, and async generator methods. In that PR it included a call toSetFunctionName, which was correspondingly factored out of the evaluation semantics of plain methods and async methods, but not generator methods or async generator methods. In the evaluation semantics for generator (and async generator) methods, there's another property (.prototype) which is added between the call toSetFunctionNameandDefineMethodProperty, and since property creation order is observable dropping the first call and just letting it happen inDefineMethodPropertywould be an observable change.Instead, just remove
SetFunctionNamefromDefineMethodProperty, and restore it to the evaluation semantics for plain and async methods. It doesn't really belong inDefineMethodProperty.(I'm pretty sure I introduced this bug by accident rebasing #1668.)
This was definitely unintentional, and fails an assert (in
SetFunctionName). So I'm calling it editorial.Thanks to @devsnek for the catch.