[immutable-arraybuffer] Coverage for read-only TypedArray methods#4547
Merged
gibson042 merged 5 commits intoMay 17, 2026
Merged
Conversation
67 tasks
504e309 to
97ab546
Compare
97ab546 to
b283db3
Compare
iamstolis
reviewed
Oct 8, 2025
c56cecc to
bf50c61
Compare
ptomato
approved these changes
May 16, 2026
Contributor
ptomato
left a comment
There was a problem hiding this comment.
I did only skim the large commit, but the newly added tests look correct to me. Don't forget to autosquash before merging.
bf50c61 to
9e07366
Compare
…acked by an immutable ArrayBuffer
9e07366 to
09020d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #4509
Note that the "Cover existing read-only TypedArray methods" commit is large but mostly mechanical, the others are small and actually specific to immutable ArrayBuffer.